-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, executor: add stale read compatibility for temporary table #25206
planner, executor: add stale read compatibility for temporary table #25206
Conversation
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
1 similar comment
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
…db into temporary_table_stale_read
/run-check_dev_2 |
@djshow832: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about IsStaleness
instead of ExplicitStaleness
? I am OK to ExplicitStaleness
, though. Will approve anyway after the response.
@xhebox The word |
@icditwang But it will be |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4bfdcdc
|
Does it need to pick to 5.1? |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #25786 |
The temporary table is not GA in 5.1, it will be GA in 5.1.1. We are cherry-picking it to release-5.1. @nolouch |
What problem does this PR solve?
Temporary table should not perform stale read
What is changed and how it works?
Add member variable
ExplicitStaleness
to builder to mark if this query statement should use stale read explicitly. If the txn is staleness or query is marked staleness, temporary table read should be fail.Related changes
N/A
Check List
Tests
Side effects
N/A
Release note