upgrade will fail when tidb system variable tidb_evolve_plan_baselines =on

[seiya-annie]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

1. before upgrade set tidb_evolve_plan_baselines =on
2. upgrade to v5.2.0

2. What did you expect to see? (Required)

upgrade success

3. What did you see instead (Required)

fail with ] [terror.go:276] ["unexpected error"] [error="Cannot enable baseline evolution feature, it is not generally available now"]
[2021/08/13 11:48:38.563 +08:00] [FATAL] [terror.go:276] ["unexpected error"] [error="Cannot enable baseline evolution feature, it is not generally available now"] [stack="github.com/pingcap/parser/terror.MustNil\n\t/nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210803205906-cece3020391a/terror/terror.go:276\nmain.createStoreAndDomain\n\t/home/jenkins/agent/workspace/optimization-build-tidb-linux-amd/go/src/github.com/pingcap/tidb/tidb-server/main.go:290\nmain.main\n\t/home/jenkins/agent/workspace/optimization-build-tidb-linux-amd/go/src/github.com/pingcap/tidb/tidb-server/main.go:190\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225"] [stack="github.com/pingcap/parser/terror.MustNil\n\t/nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210803205906-cece3020391a/terror/terror.go:276\nmain.createStoreAndDomain\n\t/home/jenkins/agent/workspace/optimization-build-tidb-linux-amd/go/src/github.com/pingcap/tidb/tidb-server/main.go:290\nmain.main\n\t/home/jenkins/agent/workspace/optimization-build-tidb-linux-amd/go/src/github.com/pingcap/tidb/tidb-server/main.go:190\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225"]

4. What is your TiDB version? (Required)

| Release Version: v5.2.0
Edition: Community
Git Commit Hash: 30cf15a59db11c34ffe05fc926152a43327eaa61
Git Branch: heads/refs/tags/v5.2.0
UTC Build Time: 2021-08-09 12:01:42
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false |```

[Reminiscent]

/assign

[Reminiscent]

It's expected. The feature for tidb_evolve_plan_baselines in new version is forbidden. We will add this to the upgrade checklist.

[Reminiscent]

/close

[ti-chi-bot]

@Reminiscent: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Not a bug

1. Remove the 'type/bug' label
2. Add notes to indicate why it is not a bug

Duplicate bug

1. Add the 'type/duplicate' label
2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

[Reminiscent]

Here is the doc pr.