Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide TemporaryTableDDL to mange temporary table ddl opeartions. #27775

Closed
Tracked by #26952
lcwangchao opened this issue Sep 2, 2021 · 0 comments · Fixed by #27776
Closed
Tracked by #26952

Provide TemporaryTableDDL to mange temporary table ddl opeartions. #27775

lcwangchao opened this issue Sep 2, 2021 · 0 comments · Fixed by #27776

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Sep 2, 2021

We have too many temporary table states in session.variables and they are exposed to users directly. For example, when dropping a local temporary table, the ddl executor should invoke sessVars.LocalTemporaryTables.RemoveTable first and then clear the table's data in sessVars.TemporaryTableData.

To decouple those codes, we should introduce a package to manage these operations and provide unified APIs. For the ddl operations this pr introduces a new interface TemporaryTableDDL to do the ddl things. It hides detail states in session.variable and the users should not care about it.

@lcwangchao lcwangchao changed the title Provide TemporaryTableManager to mange temporary tables and providing methods like AddTable , RemoveTable ... Provide TemporaryTableDDL to mange temporary table ddl opeartions. Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant