-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Introduce TemporaryTableDDL
to provide unified APIs for temporary table ddl operations
#27776
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
TemporaryTableManager
to provide unified APIs for temporary table ddl opeartionsTemporaryTableManager
to provide unified APIs for temporary table ddl opeartions
TemporaryTableManager
to provide unified APIs for temporary table ddl opeartionsTemporaryTableDDL
to provide unified APIs for temporary table ddl operations
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 12e035c
|
@lcwangchao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #27775
Problem Summary:
We have too many temporary table states in
session.variables
and they are exposed to users directly. For example, when dropping a local temporary table, the ddl executor should invokesessVars.LocalTemporaryTables.RemoveTable
first and then clear the table's data insessVars.TemporaryTableData
.To decouple those codes, we should introduce a package to manage these operations and provide unified APIs. For the ddl operations this pr introduces a new interface
TemporaryTableDDL
to do the ddl things. It hides detail states insession.variable
and the users should not care about it.The defination of
TemporaryTableDDL
is:The current pr only provides some ddl APIs. More works will be done in later prs.
The pr is also required by #26952 to provide some methods to custom snapshot retrievers. You can see the draft here: #26948
What is changed and how it works?
Introduce TemporaryTableDDL to provide unified APIs for temporary table ddl operations
Check List
Tests
Release note