Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable test TestModifyOneByte/encrypted #28299

Closed
Tracked by #25899
tisonkun opened this issue Sep 23, 2021 · 6 comments · Fixed by #28332
Closed
Tracked by #25899

unstable test TestModifyOneByte/encrypted #28299

tisonkun opened this issue Sep 23, 2021 · 6 comments · Fixed by #28332
Assignees
Labels
type/bug The issue is confirmed as a bug.

Comments

@tisonkun
Copy link
Contributor

This line now creates unstable test

[2021-09-23T16:00:22.934Z] --- FAIL: TestModifyOneByte (0.00s)
[2021-09-23T16:00:22.934Z]     --- FAIL: TestModifyOneByte/encrypted (0.00s)
[2021-09-23T16:00:22.934Z]         checksum_test.go:179: 
[2021-09-23T16:00:22.934Z]             	Error Trace:	checksum_test.go:179
[2021-09-23T16:00:22.934Z]             	            				checksum_test.go:150
[2021-09-23T16:00:22.934Z]             	Error:      	Target error should be in err chain:
[2021-09-23T16:00:22.934Z]             	            	expected: "error checksum"
[2021-09-23T16:00:22.934Z]             	            	in chain: 
[2021-09-23T16:00:22.934Z]             	Test:       	TestModifyOneByte/encrypted

Originally posted by @tisonkun in #26252 (comment)

@tisonkun
Copy link
Contributor Author

@Ranxy please take a look. Also we almost use require package for assertion.

@tisonkun
Copy link
Contributor Author

--- FAIL: TestModifyOneByte (0.00s)
    --- FAIL: TestModifyOneByte/encrypted (0.00s)
        checksum_test.go:179: 
            	Error Trace:	checksum_test.go:179
            	            				checksum_test.go:150
            	Error:      	Target error should be in err chain:
            	            	expected: "error checksum"
            	            	in chain: 
            	Test:       	TestModifyOneByte/encrypted
            	Messages:   	err: <nil>
FAIL
exit status 1
FAIL	github.com/pingcap/tidb/util/checksum	0.252s

you can use a script to forever run util failure

while go test -count=1; do; done

@tisonkun tisonkun added the type/bug The issue is confirmed as a bug. label Sep 23, 2021
@tisonkun
Copy link
Contributor Author

... also cc @mmyj @wshwsh12 since @mmyj is the author of this package and @wshwsh12 add the original test. This test is originally TestTiCase3646.

@Ranxy
Copy link
Contributor

Ranxy commented Sep 25, 2021

/assign

@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

@tisonkun
Copy link
Contributor Author

@Ranxy thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants