util/checksum: migrate to testify

[Ranxy]

What problem does this PR solve?

Issue Number: close #26169

What is changed and how it works?

What's Changed:
remove pingcap/check for utils/hack
refactor duplicate code

Release note

• No release note.

[Ranxy]

/run-check_dev

[Ranxy]

/cc @tiancaiamao @xhebox @disksing @tisonkun

[tisonkun]

Thanks for submitting this PR @Ranxy !

May you shuffle helper functions after test functions? Always we focus on test functions first and optionally take a look at its helpers.

[ti-chi-bot]

@tisonkun: Request changes is only allowed for the reviewers in list.

In response to this:

Thanks for submitting this PR @Ranxy !

May you shuffle helper functions after test functions? Always we focus on test functions first and optionally take a look at its helpers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Ranxy]

@tisonkun Updated.

[xhebox]

Rest LGTM

[tisonkun]

@Ranxy I'm creating a PR for you, please wait to make other changes.

[tisonkun]

@Ranxy you can take a look at Ranxy#1 .

[tisonkun]

I've created a PR for you. You can take a look at Ranxy#1 .

Basically it reduces unnecessary file operation and improve ticase comments.

[Ranxy]

@tisonkun Your modifications are very effective, and I think @xhebox's proposal is also very good, and we can completely replace File with the following bytes.buffer. which do you think is better?

type fakeFile struct {
	buf *bytes.Buffer
}
func (f *fakeFile) Write(p []byte) (n int, err error) {
	return f.buf.Write(p)
}
func (f *fakeFile) Close() error {
	return nil
}
func (f *fakeFile) ReadAt(p []byte, off int64) (n int, err error) {
	w := f.buf.Bytes()
	lp := int64(len(p))
	lw := int64(len(w))
	if off > lw {
		return 0, io.EOF
	}
	if off+lp > lw {
		copy(p[:lw-off], w[off:])
		return int(lw - off), io.EOF
	}
	copy(p, w[off:off+lp])
	return len(p), nil
}

[tisonkun]

@Ranxy you can integrate two comments and I think Close for byte buffer is redundant.

The parallelism refactor and ticase comment update in the PR Ranxy#1 are still valid and should be included in the final change set IMO :P

[Ranxy]

/run-check_dev_2

[tisonkun]

LGTM

[ti-chi-bot]

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[xhebox]

Rest LGTM

[Ranxy]

/run-check_dev_2

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• tiancaiamao
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[Ranxy]

/run-check_dev_2

[Ranxy]

@tiancaiamao @xhebox Thanks for your review! May you help with merging this PR?

[tiancaiamao]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: ddd56a0

[tisonkun]

This line now creates unstable test

[2021-09-23T16:00:22.934Z] --- FAIL: TestModifyOneByte (0.00s)
[2021-09-23T16:00:22.934Z]     --- FAIL: TestModifyOneByte/encrypted (0.00s)
[2021-09-23T16:00:22.934Z]         checksum_test.go:179: 
[2021-09-23T16:00:22.934Z]             	Error Trace:	checksum_test.go:179
[2021-09-23T16:00:22.934Z]             	            				checksum_test.go:150
[2021-09-23T16:00:22.934Z]             	Error:      	Target error should be in err chain:
[2021-09-23T16:00:22.934Z]             	            	expected: "error checksum"
[2021-09-23T16:00:22.934Z]             	            	in chain: 
[2021-09-23T16:00:22.934Z]             	Test:       	TestModifyOneByte/encrypted