Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Prepare Plancache and binding compatibility issues #29539

Closed
nickzabc opened this issue Nov 8, 2021 · 1 comment · Fixed by #30169
Closed

The Prepare Plancache and binding compatibility issues #29539

nickzabc opened this issue Nov 8, 2021 · 1 comment · Fixed by #30169
Assignees
@qw4990 @Reminiscent
Labels
epic/plan-cache sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@nickzabc
Copy link

nickzabc commented Nov 8, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

When the Prepare Plancache function is enabled, when the user uses Binding to bind the execution plan, if the bound SQL is cached by Plancache, the Binding cannot be performed.

Therefore, Binding is required to take precedence over Plancache.

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

5.3.0
@nickzabc nickzabc added the type/bug The issue is confirmed as a bug. label Nov 8, 2021
@ChenPeng2013 ChenPeng2013 added the sig/planner SIG: Planner label Nov 8, 2021
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. severity/major labels Nov 8, 2021
@qw4990
Copy link
Contributor

qw4990 commented Nov 25, 2021

Statistics also have this problem. (cached plans remain unchanged after updating statistics)

@qw4990 qw4990 mentioned this issue Dec 7, 2021
Merged
12 tasks
This was referenced Jan 11, 2022
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qw4990 qw4990

@Reminiscent Reminiscent

Labels
epic/plan-cache sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: support the plan cache aware of bindings Reminiscent/tidb
4 participants
@ChenPeng2013 @qw4990 @Reminiscent @nickzabc