Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: improve the bindSQL check for plan cache #31054

Merged
merged 4 commits into from
Dec 28, 2021

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Dec 27, 2021

What problem does this PR solve?

Issue Number: close #31036

Problem Summary:
The check for BindSQL is too slow. We need to optimize it.

What is changed and how it works?

The prepared statement will not change. So we can pre-calculate the NormalizedSQL. And use it to find the binding directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent added type/enhancement The issue or PR belongs to an enhancement. type/bugfix This PR fixes a bug. sig/planner SIG: Planner epic/plan-cache labels Dec 27, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 27, 2021

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 28, 2021
@Reminiscent Reminiscent marked this pull request as ready for review December 28, 2021 04:08
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 28, 2021
@Reminiscent Reminiscent changed the title planner: improve the bindSQL for plan cache planner: improve the bindSQL check for plan cache Dec 28, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2021
@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 590b806

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@Reminiscent Reminiscent merged commit 57b2908 into pingcap:master Dec 28, 2021
@Reminiscent Reminiscent deleted the optimizeBindSQL4PC branch December 28, 2021 07:28
@Reminiscent
Copy link
Contributor Author

related to #29539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #30169 results in 6.1%-6.6% performance regression in read-heavy workloads
5 participants