-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: improve the bindSQL check for plan cache #31054
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6ff5d62b1f70613decf15ba58e4f16198d8f65ee |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 590b806
|
related to #29539 |
What problem does this PR solve?
Issue Number: close #31036
Problem Summary:
The check for
BindSQL
is too slow. We need to optimize it.What is changed and how it works?
The prepared statement will not change. So we can pre-calculate the NormalizedSQL. And use it to find the binding directly.
Check List
Tests
Side effects
Documentation
Release note