Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: after br restore, tikv used storage is not balance #31034

Closed
mayjiang0203 opened this issue Dec 27, 2021 · 6 comments · Fixed by #31691
Closed

br: after br restore, tikv used storage is not balance #31034

mayjiang0203 opened this issue Dec 27, 2021 · 6 comments · Fixed by #31691
Assignees
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. component/br This issue is related to BR of TiDB. found/automation Found by automation tests severity/major type/bug The issue is confirmed as a bug.

Comments

@mayjiang0203
Copy link

mayjiang0203 commented Dec 27, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

run oltp_fun_001

2. What did you expect to see? (Required)

Restore finished at 18:26. Tikv used should be balance in all nodes.

3. What did you see instead (Required)

image

4. What is your TiDB version? (Required)

/ # /br -V
Release Version: v5.4.0-nightly
Git Commit Hash: 76aae0d
Git Branch: heads/refs/tags/v5.4.0-nightly
Go Version: go1.16.4
UTC Build Time: 2021-12-26 08:07:37
Race Enabled: false

/ # /tidb-server -V
Release Version: v5.4.0-nightly
Edition: Community
Git Commit Hash: 76aae0d
Git Branch: heads/refs/tags/v5.4.0-nightly
UTC Build Time: 2021-12-26 08:09:11
GoVersion: go1.16.4
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false

Logs and monitor can be get from minio using following testbed name.
endless-oltp--tps-542284-1-875

@mayjiang0203 mayjiang0203 added type/bug The issue is confirmed as a bug. found/automation Found by automation tests labels Dec 27, 2021
@mayjiang0203
Copy link
Author

Seems it is hard to reproduce it. Didn't occur after try 4 times.
image

@YuJuncen
Copy link
Contributor

YuJuncen commented Dec 30, 2021

I've checked some of metrics. There are some strange things:

  1. PD failed to create operator because of unhealthy regions. This can be retried after we using the new ScatterRegions API.
  2. Seems BR sometimes scatters non-empty region. (Even every region are empty, the 'pending' status still exists.)

@mayjiang0203
Copy link
Author

It occur again, seems still caused by scatter failure.
image

@mayjiang0203
Copy link
Author

Hit it again, and it take user 30 min to balance after br import, so mark it Major.
image

@jebter jebter added the affects-5.4 This bug affects 5.4.x versions. label Jan 18, 2022
@YuJuncen YuJuncen added the affects-5.3 This bug affects 5.3.x versions. label Jan 19, 2022
@YuJuncen
Copy link
Contributor

YuJuncen commented Jan 19, 2022

Note that v5.4 contains #30899, which can probably allay this problem.

#31691 would fix this problem.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. component/br This issue is related to BR of TiDB. found/automation Found by automation tests severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants