Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-lightning import wrong data if user doesn't has right permission #31088

Closed
glorv opened this issue Dec 28, 2021 · 1 comment · Fixed by #31089
Closed

tidb-lightning import wrong data if user doesn't has right permission #31088

glorv opened this issue Dec 28, 2021 · 1 comment · Fixed by #31089
Assignees
@glorv
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@glorv
Copy link
Contributor

glorv commented Dec 28, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Use tidb-lightning to import data into a v5.3.0 cluster with (new_collations_enabled_on_first_bootstrap=true). The user in tidb-lightning's config doesn't has permission to access to table mysql.tidb

2. What did you expect to see? (Required)

The import should either return an error or import success.

3. What did you see instead (Required)

TiDB-Lightning return success but data in target db is not consistent.

4. What is your TiDB version? (Required)
@glorv glorv added type/bug The issue is confirmed as a bug. component/lightning This issue is related to Lightning of TiDB. labels Dec 28, 2021
@glorv glorv mentioned this issue Dec 28, 2021
Merged
12 tasks
@fubinzh fubinzh added severity/major affects-5.3 This bug affects 5.3.x versions. labels Dec 29, 2021
@fubinzh fubinzh mentioned this issue Dec 29, 2021
Open
ti-chi-bot pushed a commit that referenced this issue Dec 30, 2021
@glorv
lightning: don't ignore error if check new collation failed (#31089)
9325c91 
close #31088
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

This was referenced Dec 30, 2021
Merged
Merged
@jebter jebter added the affects-5.2 This bug affects 5.2.x versions. label Dec 31, 2021
@djshow832 djshow832 mentioned this issue Jan 10, 2022
Merged
14 tasks
ti-chi-bot pushed a commit that referenced this issue Feb 17, 2022
@ti-srebot
lightning: don't ignore error if check new collation failed (#31089) (#…
921ca98 
…31152)

close #31088
YuJuncen pushed a commit to pingcap/br that referenced this issue Mar 1, 2022
@glorv
lightning: don't ignore error if check new collation failed (#31089)
7a1e3aa 
close pingcap/tidb#31088
ti-chi-bot pushed a commit that referenced this issue Apr 13, 2022
@ti-srebot
lightning: don't ignore error if check new collation failed (#31089) (#…
13839f8 
…31151)

close #31088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glorv glorv

Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: don't ignore error if check new collation failed glorv/tidb
3 participants
@jebter @glorv @fubinzh