Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not allow specify FOLLOWERS/LEARNERS when FOLLOWER_CONSTRAINTS/LEARNER_CONSTRAINTS is using dict syntax #31127

Closed
Tracked by #18030
lcwangchao opened this issue Dec 29, 2021 · 0 comments · Fixed by #31133
Assignees

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Dec 29, 2021

We should forbid the following syntax:

create placement policy p1 LEARNER_CONSTRAINTS="{+region=r1: 1}" LEARNERS=1;
create placement policy p1 FOLLOWER_CONSTRAINTS="{+region=r1: 1}" FOLLOWERS=1;
create table t1(id int) LEARNER_CONSTRAINTS="{+region=r1: 1}" LEARNERS=1;
create table t1(id int) FOLLOWER_CONSTRAINTS="{+region=r1: 1}" FOLLOWERS=1;
@lcwangchao lcwangchao changed the title Forbid dict syntax with followers=xxx/learners=xxx Should not allow specify FOLLOWERS/LEARNERS when FOLLOWER_CONSTRAINTS/LEARNER_CONSTRAINTS is using dict syntax Dec 29, 2021
@xhebox xhebox self-assigned this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants