Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: do not use analyze version 2 as default config for new clusters since it was an experimental feature #31748

Closed
yiwen92 opened this issue Jan 17, 2022 · 4 comments
Closed

statistics: do not use analyze version 2 as default config for new clusters since it was an experimental feature #31748

yiwen92 opened this issue Jan 17, 2022 · 4 comments
Assignees
@yiwen92
Labels
affects-6.2 affects-6.3 affects-6.4 severity/major sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@yiwen92
Copy link
Contributor

yiwen92 commented Jan 17, 2022

Enhancement

Since a lot of customers reported OOM when they are doing analyze table due to tidb_analyze_version = 2 in v5.1 and v5.2, and as this was defined as experimental feature, so we suggest not to use version 2 by default. Let's keep tidb_analyze_version = 1 as default set for v5.1.x and v5.2.x.

affected version: v5.1.x and v5.2.x.
@yiwen92 yiwen92 added the type/enhancement The issue or PR belongs to an enhancement. label Jan 17, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Jan 17, 2022

/assign @yudongusa PTAL.

@yiwen92
Copy link
Contributor Author

yiwen92 commented Jan 18, 2022

/label type/bug affects-5.1 affects-5.2

@aytrack aytrack added affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. type/bug The issue is confirmed as a bug. severity/major and removed type/enhancement The issue or PR belongs to an enhancement. labels Jan 18, 2022
@yiwen92
Copy link
Contributor Author

yiwen92 commented Jan 19, 2022

/assign @yiwen92

@yiwen92 yiwen92 mentioned this issue Jan 19, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Feb 10, 2022
@yiwen92
statistics: change default value of tidb_analyze_version to 1 (#31826)
094b3e5 
close #31748
This was referenced Feb 17, 2022
Closed
Merged
@ti-chi-bot ti-chi-bot mentioned this issue Mar 3, 2022
Merged
14 tasks
yiwen92 added a commit to yiwen92/tidb that referenced this issue Apr 9, 2022
@yiwen92
statistics: change default value of tidb_analyze_version to 1 (pingca…
7c2b51c 
…p#31826)

close pingcap#31748
@yiwen92 yiwen92 mentioned this issue Apr 9, 2022
Merged
12 tasks
@VelocityLight VelocityLight added affects-5.4 This bug affects 5.4.x versions. and removed affects-5.4 This bug affects 5.4.x versions. labels Apr 11, 2022
ti-chi-bot pushed a commit that referenced this issue Apr 13, 2022
@yiwen92
statistics: change default value of tidb_analyze_version to 1 (#31826) (
50e35e6 
#33841)

close #31748
@windtalker
Copy link
Contributor

I think it is an enhancement rather than a bug, so remove all the affects-xxx label.

@windtalker windtalker added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-6.1 labels May 23, 2022
@jebter jebter added the sig/planner SIG: Planner label Jul 26, 2022
@jebter jebter closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiwen92 yiwen92

Labels
affects-6.2 affects-6.3 affects-6.4 severity/major sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@windtalker @jebter @VelocityLight @aytrack @yiwen92