Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cached table can't use prepare plan cache, that's not acceptable! #32003

Closed
tiancaiamao opened this issue Jan 27, 2022 · 1 comment · Fixed by #32139
Closed

cached table can't use prepare plan cache, that's not acceptable! #32003

tiancaiamao opened this issue Jan 27, 2022 · 1 comment · Fixed by #32139
Assignees
@tiancaiamao
Labels
feature/developing the related feature is in development severity/critical type/bug The issue is confirmed as a bug.

Comments

@tiancaiamao
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Core banking workload, 'alter table cache' for some tables, I expect the QPS increase, latency decrease.
But since the current implementation can't reuse plan cache, the performance decrease!

2. What did you expect to see? (Required)

Cached table must be able to use the plan cache.

3. What did you see instead (Required)

Current implement do not handle it.

4. What is your TiDB version? (Required)

master developing...
@tiancaiamao tiancaiamao added type/bug The issue is confirmed as a bug. severity/critical feature/developing the related feature is in development labels Jan 27, 2022
@tiancaiamao tiancaiamao self-assigned this Jan 27, 2022
@ti-chi-bot ti-chi-bot added may-affects-2.1 may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Jan 27, 2022
@tiancaiamao
Copy link
Contributor Author

Link #25293

@tiancaiamao tiancaiamao removed may-affects-2.1 may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Jan 27, 2022
@tiancaiamao tiancaiamao mentioned this issue Feb 7, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Feb 14, 2022
@tiancaiamao
*: support prepared plan cache for cached table (#32139)
1cf4fcf 
close #32003
@tiancaiamao tiancaiamao mentioned this issue Feb 14, 2022
Closed
32 tasks
tiancaiamao added a commit to tiancaiamao/tidb that referenced this issue Feb 21, 2022
@tiancaiamao
*: support prepared plan cache for cached table (pingcap#32139)
0008d91 
close pingcap#32003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiancaiamao tiancaiamao

Labels
feature/developing the related feature is in development severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: support prepared plan cache for cached table tiancaiamao/tidb
2 participants
@tiancaiamao @ti-chi-bot