Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR stuck when restore meet unrecoverable errors. #33200

Closed
YuJuncen opened this issue Mar 17, 2022 · 0 comments · Fixed by #33201
Closed

BR stuck when restore meet unrecoverable errors. #33200

YuJuncen opened this issue Mar 17, 2022 · 0 comments · Fixed by #33201
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@YuJuncen
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Inject an error at restore.Client::RestoreFiles or SplitRegion, and run restore.

2. What did you expect to see? (Required)

Restore exits and report fail in a reasonable time.

3. What did you see instead (Required)

BR stuck.

4. What is your TiDB version? (Required)

Master.
@YuJuncen YuJuncen added the type/bug The issue is confirmed as a bug. label Mar 17, 2022
YuJuncen added a commit to YuJuncen/tidb that referenced this issue Mar 17, 2022
@YuJuncen
fix pingcap#33200: select over the context generated by error group
c6a54a4 
Signed-off-by: Yu Juncen <yu745514916@live.com>
@YuJuncen YuJuncen mentioned this issue Mar 17, 2022
Merged
1 task
@YuJuncen YuJuncen added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-5.3 This bug affects 5.3.x versions. affects-6.0 severity/minor labels Mar 17, 2022
ti-chi-bot pushed a commit that referenced this issue Mar 21, 2022
@YuJuncen
br: Fix stuck when meeting error (#33201)
49f291d 
close #33200
This was referenced Mar 21, 2022
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Mar 25, 2022
@ti-srebot
br: Fix stuck when meeting error (#33201) (#33269)
eacba78 
close #33200
@tiancaiamao tiancaiamao added the component/br This issue is related to BR of TiDB. label Apr 27, 2022
ti-chi-bot pushed a commit that referenced this issue Jun 17, 2022
@ti-srebot
br: Fix stuck when meeting error (#33201) (#33267)
adc6743 
close #33200
ti-chi-bot pushed a commit that referenced this issue Jun 23, 2022
@ti-srebot
br: Fix stuck when meeting error (#33201) (#33268)
1f8716d 
close #33200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: Fix stuck when meeting error YuJuncen/tidb
2 participants
@tiancaiamao @YuJuncen