-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A smarter way to scatter batch regions #33937
Labels
component/br
This issue is related to BR of TiDB.
component/lightning
This issue is related to Lightning of TiDB.
component/pd
type/enhancement
The issue or PR belongs to an enhancement.
Comments
3pointer
added
type/enhancement
The issue or PR belongs to an enhancement.
component/br
This issue is related to BR of TiDB.
component/lightning
This issue is related to Lightning of TiDB.
labels
Apr 13, 2022
5> Finish the rest split and scatter. |
I think only split is ok, it works for BR/Lightning and it may save lots of time. |
BTW. we can make the strategy implemented in the PD server, then Multiple downstream multiple implementations can be prevented. there is a pr relative it: tikv/pd#4778 |
cc #27234 |
This was referenced Sep 21, 2022
13 tasks
AilinKid
pushed a commit
to AilinKid/tidb
that referenced
this issue
Jan 17, 2024
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/br
This issue is related to BR of TiDB.
component/lightning
This issue is related to Lightning of TiDB.
component/pd
type/enhancement
The issue or PR belongs to an enhancement.
Enhancement
Both Lightning and BR will do batch split & scatter regions job to make the data import evenly. but this seems not work as expected when we have lots of stores(100+).
basic there are three reasons:
tidb/br/pkg/restore/split_client.go
Line 436 in 951bc42
According to the metrics. we can see that when request a 8k regions scatter. there are half(4.4k) failed to scatter.
To solve this issue.I think we can do a pre-split/scatter job.
Suppose we have lots of stores(100+) and we know the a batch split/scatter size is 8k. we can do the following things
With this change. we can make the full use of tikv store. make each of them do split scatter evenly.
The text was updated successfully, but these errors were encountered: