Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: the br panic on tikv client-go when do backup #34956

Closed
joccau opened this issue May 25, 2022 · 4 comments
Closed

br: the br panic on tikv client-go when do backup #34956

joccau opened this issue May 25, 2022 · 4 comments
Assignees
Labels
component/br This issue is related to BR of TiDB. may-affects-5.4 This bug maybe affects 5.4.x versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@joccau
Copy link
Member

joccau commented May 25, 2022

Bug Report

  • BR version
    [release-version=v5.4.0] [git-hash=55f3b24c1c9f506bd652ef1d162283541e428872] [git-branch=heads/refs/tags/v5.4.0] [go-version=go1.16.4] [utc-build-time="2022-01-25 08:36:34"]

  • Panic stack
    github.com/tikv/client-go/v2/internal/client.interceptedClient.SendRequest(0x40439a8, 0xc000c5b500, 0x4065210, 0xc0008fc580, 0xc000f99180, 0x39, 0xc00f6f1e00, 0x6fc23ac00, 0x203003, 0x203003, ...)
    --
    /nfs/cache/mod/github.com/tikv/client-go/v2@v2.0.0-rc.0.20211229051614-62d6b4a2e8f7/internal/client/client.go:410 +0x275
    /nfs/cache/mod/github.com/tikv/client-go/v2@v2.0.0-rc.0.20211229051614-62d6b4a2e8f7/internal/client/client_collapse.go:74 +0x12a
    /nfs/cache/mod/google.golang.org/grpc@v1.29.1/clientconn.go:514
    github.com/tikv/client-go/v2/internal/client.(*RPCClient).SendRequest(0xc000c5b500, 0x4065210, 0xc0008fc580, 0xc000f99180, 0x39, 0xc00f6f1e00, 0x6fc23ac00, 0x0, 0x0, 0x0)
    github.com/tikv/client-go/v2/internal/client.interceptedClient.SendRequest(0x40439a8, 0xc000c5b500, 0x4065210, 0xc0008fc580, 0xc000f99180, 0x39, 0xc00f6f1e00, 0x6fc23ac00, 0x203003, 0x203003, ...)
    I0524 03:58:28.807851 9 backup.go:100] panic: runtime error: invalid memory address or nil pointer dereference
     
    goroutine 13166 [running]:
    github.com/tikv/client-go/v2/internal/client.reqCollapse.SendRequest(0x4045a00, 0xc000adc030, 0x4065210, 0xc0008fc580, 0xc000f99180, 0x39, 0xc00f6f1e00, 0x6fc23ac00, 0x39e0f40, 0x1, ...)
    /nfs/cache/mod/github.com/tikv/client-go/v2@v2.0.0-rc.0.20211229051614-62d6b4a2e8f7/tikv/kv.go:538 +0x145
    I0524 03:58:28.807762 9 backup.go:93]
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x228 pc=0x1d32b75]
    google.golang.org/grpc.(*ClientConn).GetState(...)
    github.com/tikv/client-go/v2/tikv.(*KVStore).updateSafeTS.func1(0x40439d0, 0xc000adc040, 0xc000a90640, 0x4065210, 0xc0008fc580, 0xc010991d20, 0x11, 0xc000f99180, 0x39)
    /nfs/cache/mod/github.com/tikv/client-go/v2@v2.0.0-rc.0.20211229051614-62d6b4a2e8f7/tikv/kv.go:540 +0x165
    created by github.com/tikv/client-go/v2/tikv.(*KVStore).updateSafeTS
    /nfs/cache/mod/github.com/tikv/client-go/v2@v2.0.0-rc.0.20211229051614-62d6b4a2e8f7/internal/client/client_interceptor.go:42 +0x1e9

  • It is about https://jira.tidbcloud.com/browse/TCOC-451

@joccau joccau added the type/bug The issue is confirmed as a bug. label May 25, 2022
@joccau
Copy link
Member Author

joccau commented May 25, 2022

@joccau joccau added the component/br This issue is related to BR of TiDB. label May 25, 2022
@joccau
Copy link
Member Author

joccau commented May 25, 2022

/assign

@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 labels May 26, 2022
@joccau joccau removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-6.1 may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 labels May 27, 2022
ti-chi-bot pushed a commit that referenced this issue May 30, 2022
@joccau
Copy link
Member Author

joccau commented Jul 20, 2022

/close

@ti-chi-bot
Copy link
Member

@joccau: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. may-affects-5.4 This bug maybe affects 5.4.x versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants