Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the entrance of new transaction. #35705

Closed
Tracked by #30535
SpadeA-Tang opened this issue Jun 24, 2022 · 1 comment · Fixed by #35679
Closed
Tracked by #30535

Unify the entrance of new transaction. #35705

SpadeA-Tang opened this issue Jun 24, 2022 · 1 comment · Fixed by #35679
Labels
affects-5.4 This bug affects 5.4.x versions. affects-6.1 report/customer Customers have encountered this bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@SpadeA-Tang
Copy link
Contributor

Enhancement

Now, we have transaction manager, which helps us to manage the transaction related things.
It includes entering a new transaction: txnManager.EnterNewTxn.
However, we can still activating a new transaction by not involving txnManager: calling session.Txn.
We should unify the transaction entrance.
@SpadeA-Tang SpadeA-Tang added the type/enhancement The issue or PR belongs to an enhancement. label Jun 24, 2022
@SpadeA-Tang SpadeA-Tang mentioned this issue Jun 24, 2022
Merged
@xhebox xhebox mentioned this issue Jun 24, 2022
Open
25 tasks
ti-chi-bot pushed a commit that referenced this issue Jun 30, 2022
@SpadeA-Tang
txn: unify the management of transaction activation by TxnManager. (#…
11f39cd 
…35679)

close #35705
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jul 5, 2024
@ti-chi-bot ti-chi-bot added affects-5.4 This bug affects 5.4.x versions. affects-6.1 labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects 5.4.x versions. affects-6.1 report/customer Customers have encountered this bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

txn: unify the management of transaction activation by TxnManager. SpadeA-Tang/tidb
3 participants
@seiya-annie @ti-chi-bot @SpadeA-Tang