Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot acquisition should be managed by transaction manager #35810

Closed
Tracked by #30535
SpadeA-Tang opened this issue Jun 29, 2022 · 0 comments · Fixed by #35788
Closed
Tracked by #30535

Snapshot acquisition should be managed by transaction manager #35810

SpadeA-Tang opened this issue Jun 29, 2022 · 0 comments · Fixed by #35788
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@SpadeA-Tang
Copy link
Contributor

SpadeA-Tang commented Jun 29, 2022

Enhancement

Now, the acquisition of snapshot is not managed by transaction manager and is usually done by first fetching appropriate tso and then use that tso to acquire snapshot. This is also mixed with some optimization which is not easy to read (the following figure shows a case). We should let txnManager to manage these and only expose simple interface outside.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant