Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-test(filesort_merge) failed. #36983

Closed
wjhuang2016 opened this issue Aug 9, 2022 · 3 comments
Closed

mysql-test(filesort_merge) failed. #36983

wjhuang2016 opened this issue Aug 9, 2022 · 3 comments
Assignees
Labels
component/test severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@wjhuang2016
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_integration_common_test/detail/tidb_ghpr_integration_common_test/12349/pipeline
0qFY5iWCvW

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

@wjhuang2016 wjhuang2016 added the type/bug The issue is confirmed as a bug. label Aug 9, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 labels Aug 9, 2022
@ChenPeng2013 ChenPeng2013 removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 labels Aug 9, 2022
@wjhuang2016 wjhuang2016 added the sig/planner SIG: Planner label Aug 9, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Aug 10, 2022

[2022/08/10 14:07:17.734 +08:00] [INFO] [handle.go:1189] ["[stats] directly update count"] [tableID=91] [results.Count=2373] [count=2373]
[2022/08/10 14:07:18.005 +08:00] [INFO] [analyze.go:426] ["analyze table `filesort_merge`.`t1` has finished"] [partition=] ["job info"="analyze table all columns with 256 buckets, 500 topn, 1 samplerate"] ["start time"=2022/08/10 14:07:17.715 +08:00] ["end time"=2022/08/10 14:07:17.980 +08:00] [cost=265.736394ms]
[2022/08/10 14:07:22.272 +08:00] [INFO] [manager.go:296] ["get owner"] ["owner info"="[log-backup] /tidb/br-stream/owner ownerManager e451b3b2-6623-4ab7-b4ae-754a5e9c9aa8"] [ownerID=e451b3b2-6623-4ab7-b4ae-754a5e9c9aa8]
[2022/08/10 14:07:26.845 +08:00] [INFO] [data_window.go:248] ["Error exists when getting the SQL Metric."]
[2022/08/10 14:07:32.551 +08:00] [INFO] [update.go:1133] ["[stats] auto analyze triggered"] [sql="analyze table `filesort_merge`.`t1`"] [reason="too many modifications(3072/2373>0.5)"]

From log we can find that 2373 is directly returned by analyze response Count from TiKV. A possibility root cause is about to txn isolation level.

The default isolation level is RC as following:

// SetAnalyzeRequest sets the request type to "ReqTypeAnalyze" and construct request data.
func (builder *RequestBuilder) SetAnalyzeRequest(ana *tipb.AnalyzeReq) *RequestBuilder {
if builder.err == nil {
builder.Request.Tp = kv.ReqTypeAnalyze
builder.Request.Data, builder.err = ana.Marshal()
builder.Request.NotFillCache = true
builder.Request.IsolationLevel = kv.RC
builder.Request.Priority = kv.PriorityLow
}
return builder
}

and the testcase failed about 5 or 6 times once. After I changed it into SI, the testcase success 20 times in a row on my local env.

@Yisaer
Copy link
Contributor

Yisaer commented Aug 11, 2022

As the tikv analyze response returned wrong value, I transfer this issue into tikv/tikv#13258

ti-chi-bot pushed a commit that referenced this issue Aug 11, 2022
@Yisaer Yisaer mentioned this issue Aug 11, 2022
1 task
ti-chi-bot pushed a commit that referenced this issue Aug 12, 2022
@Yisaer
Copy link
Contributor

Yisaer commented Aug 15, 2022

I will close this issue as it seems we won't see this error in mysql-test now. Further information will be tracked in tikv/tikv#13258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants