Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: set system var dpanic #37266

Closed
sleepymole opened this issue Aug 22, 2022 · 3 comments · Fixed by #37301
Closed

lightning: set system var dpanic #37266

sleepymole opened this issue Aug 22, 2022 · 3 comments · Fixed by #37301
Labels
component/lightning This issue is related to Lightning of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@sleepymole
Copy link
Contributor

sleepymole commented Aug 22, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Use tidb-lightning to import data.

2. What did you expect to see? (Required)

Import successfuly.

3. What did you see instead (Required)

Import successfuly but there are a lot of DPANIC logs.

[2022/08/22 15:19:52.768 +08:00] [DPANIC] [session.go:268] ["new session: failed to set system var"] [tableName=`tpcc`.`orders`] [error="[variable:1238]Variable 'lc_time_names' is a read only variable"] [key=lc_time_names] [stack="github.com/pingcap/tidb/br/pkg/lightning/backend/kv.newSession\n\t/root/tidb/br/pkg/lightning/backend/kv/session.go:268\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/kv.NewTableKVDecoder\n\t/root/tidb/br/pkg/lightning/backend/kv/kv2sql.go:114\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.NewDuplicateManager\n\t/root/tidb/br/pkg/lightning/backend/local/duplicate.go:419\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*local).CollectRemoteDuplicateRows\n\t/root/tidb/br/pkg/lightning/backend/local/local.go:1652\ngithub.com/pingcap/tidb/br/pkg/lightning/backend.Backend.CollectRemoteDuplicateRows\n\t/root/tidb/br/pkg/lightning/backend/backend.go:390\ngithub.com/pingcap/tidb/br/pkg/lightning/restore.(*TableRestore).postProcess\n\t/root/tidb/br/pkg/lightning/restore/table_restore.go:778\ngithub.com/pingcap/tidb/br/pkg/lightning/restore.(*Controller).restoreTables.func7.1\n\t/root/tidb/br/pkg/lightning/restore/restore.go:1624"]
[2022/08/22 15:19:56.506 +08:00] [DPANIC] [session.go:268] ["new session: failed to set system var"] [tableName=`tpcc`.`history`] [error="[variable:1238]Variable 'lc_time_names' is a read only variable"] [key=lc_time_names] [stack="github.com/pingcap/tidb/br/pkg/lightning/backend/kv.newSession\n\t/root/tidb/br/pkg/lightning/backend/kv/session.go:268\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/kv.NewTableKVDecoder\n\t/root/tidb/br/pkg/lightning/backend/kv/kv2sql.go:114\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.NewDuplicateManager\n\t/root/tidb/br/pkg/lightning/backend/local/duplicate.go:419\ngithub.com/pingcap/tidb/br/pkg/lightning/backend/local.(*local).CollectLocalDuplicateRows\n\t/root/tidb/br/pkg/lightning/backend/local/local.go:1634\ngithub.com/pingcap/tidb/br/pkg/lightning/backend.Backend.CollectLocalDuplicateRows\n\t/root/tidb/br/pkg/lightning/backend/backend.go:386\ngithub.com/pingcap/tidb/br/pkg/lightning/restore.(*TableRestore).postProcess\n\t/root/tidb/br/pkg/lightning/restore/table_restore.go:760\ngithub.com/pingcap/tidb/br/pkg/lightning/restore.(*Controller).restoreTables.func7.1\n\t/root/tidb/br/pkg/lightning/restore/restore.go:1624"]

4. What is your TiDB version? (Required)

master

@sleepymole sleepymole added type/bug The issue is confirmed as a bug. component/lightning This issue is related to Lightning of TiDB. labels Aug 22, 2022
@sleepymole
Copy link
Contributor Author

sleepymole commented Aug 22, 2022

It seems they were not critical errors, but DPANIC sounds terrible.

@morgo
Copy link
Contributor

morgo commented Aug 22, 2022

This is caused by #30084

The issue is that it was only ever a noop / it's not safe to noop for some applications.

@D3Hunter D3Hunter added affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 and removed affects-6.0 affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 labels Aug 23, 2022
@D3Hunter
Copy link
Contributor

This is caused by #30084

caused by #36640

this var is set to readonly in 5.4, but the check added in current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/lightning This issue is related to Lightning of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants