Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: handle special character in SQL. #37469

Closed
3pointer opened this issue Aug 30, 2022 · 4 comments · Fixed by #37486
Closed

br: handle special character in SQL. #37469

3pointer opened this issue Aug 30, 2022 · 4 comments · Fixed by #37486
Assignees
@MoCuishle28
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@3pointer
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

In SQL backup/restore if sk has special character (+), we will encounter the error. just like pingcap/br#603, we handle it in binary. but the URL parsed before we replace it in SQL.

2. What did you expect to see? (Required)

success

3. What did you see instead (Required)

failed with SignatureDoesNotMatch.

4. What is your TiDB version? (Required)

v6.1.0
@3pointer 3pointer added type/bug The issue is confirmed as a bug. affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. labels Aug 30, 2022
@3pointer
Copy link
Contributor Author

we need replace (+) before this.

tidb/executor/brie.go

Line 228 in 6ae88c4

storageURL, err := url.Parse(s.Storage)

@MoCuishle28
Copy link
Contributor

/assign MoCuishle28

@MoCuishle28
Copy link
Contributor

/severity minor

@MoCuishle28 MoCuishle28 mentioned this issue Aug 30, 2022
Merged
12 tasks
@MoCuishle28
Copy link
Contributor

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Aug 30, 2022
ti-chi-bot pushed a commit that referenced this issue Sep 6, 2022
@MoCuishle28
br: handle special character in SQL (#37486)
aab394f 
close #37469
This was referenced Sep 6, 2022
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Sep 16, 2022
@ti-srebot
br: handle special character in SQL (#37486) (#37638)
2ecad39 
close #37469
ti-chi-bot pushed a commit that referenced this issue Oct 10, 2022
@ti-srebot
br: handle special character in SQL (#37486) (#37639)
9c380dd 
close #37469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoCuishle28 MoCuishle28

Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: handle special character in SQL MoCuishle28/tidb
3 participants
@3pointer @MoCuishle28 @ti-chi-bot