Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support commenting in CREATE USER and ALTER USER statements #38172

Closed
CbcWestwolf opened this issue Sep 26, 2022 · 1 comment · Fixed by #38201
Closed

Support commenting in CREATE USER and ALTER USER statements #38172

CbcWestwolf opened this issue Sep 26, 2022 · 1 comment · Fixed by #38201
Assignees
@CbcWestwolf
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@CbcWestwolf
Copy link
Member

CbcWestwolf commented Sep 26, 2022 •
edited
Loading

Comparing tidb doc with mysql doc, now the following AST structs in TiDB lack comment field.

  1. CreateUserStmt
  2. AlterUserStmt

We can supply them.

References:
@CbcWestwolf CbcWestwolf added the type/enhancement The issue or PR belongs to an enhancement. label Sep 26, 2022
@CbcWestwolf
Copy link
Member Author

/assign

@CbcWestwolf CbcWestwolf changed the title Support commenting in more sql statements Support commenting in CREATE USER and ALTER USER statements Sep 27, 2022
@CbcWestwolf CbcWestwolf mentioned this issue Sep 27, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Oct 20, 2022
@CbcWestwolf
*: support ATTRIBUTE and COMMENT in CREATE USER and `ALTER USER…
4699c7d 
…` statements (#38201)

close #38172
@dveeden dveeden mentioned this issue Nov 29, 2022
Open
70 tasks
@dveeden dveeden mentioned this issue Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CbcWestwolf CbcWestwolf

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: support ATTRIBUTE and COMMENT in CREATE USER and ALTER USER statements CbcWestwolf/tidb
1 participant
@CbcWestwolf