Noisy logging for "set resource control"

[dveeden]

https://github.com/pingcap/tidb/blame/4ed456214d985b6b8b9ed9c49078fea4524927bc/domain/domain_sysvars.go#L79

[2023/01/30 08:14:00.733 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:14:30.738 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:15:00.743 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:15:30.748 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:16:00.754 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:16:30.757 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:17:00.761 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:17:30.766 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]
[2023/01/30 08:18:00.772 +01:00] [INFO] [domain_sysvars.go:79] ["set resource control"] [enable=false]

$ ./bin/tidb-server -V
Release Version: v6.6.0-alpha-306-g28d0325ae
Edition: Community
Git Commit Hash: 28d0325ae12f080b978a147bba9f8467557019cd
Git Branch: master
UTC Build Time: 2023-01-30 06:26:21
GoVersion: go1.19.5
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: unistore

This is with running TiDB with unistore like ./bin/tidb-server.

Seems to be related to #40732

Maybe change the level to debug and/or only log this when the value of enable changes?

cc @nolouch

[BornChanger]

/assign @BornChanger

[BornChanger]

Only logging when switch changed.

[BornChanger]

@dveeden please close this bug.

[jebter]

/close

[ti-chi-bot]

@jebter: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.