Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test in util/gctuner #41280

Closed
Tracked by #41316
hnes opened this issue Feb 10, 2023 · 1 comment · Fixed by #43021
Closed
Tracked by #41316

flaky test in util/gctuner #41280

hnes opened this issue Feb 10, 2023 · 1 comment · Fixed by #43021
Labels
component/test severity/moderate type/bug The issue is confirmed as a bug.

Comments

@hnes
Copy link
Contributor

hnes commented Feb 10, 2023

Bug Report

1. Minimal reproduce step (Required)

$go test -count=10 -run Test* github.com/pingcap/tidb/util/gctuner
--- FAIL: TestGlobalMemoryTuner (2.22s)
    memory_limit_tuner_test.go:103:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:103
                Error:          Not equal:
                                expected: 858993459
                                actual  : 1181116006
                Test:           TestGlobalMemoryTuner
    memory_limit_tuner_test.go:64:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:64
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/panic.go:522
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/testing.go:871
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:103
                Error:          Should be false
                Test:           TestGlobalMemoryTuner
--- FAIL: TestTuner (0.29s)
    tuner_test.go:57:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/tuner_test.go:57
                Error:          "285" is not less than or equal to "250"
                Test:           TestTuner
--- FAIL: TestGlobalMemoryTuner (1.67s)
    memory_limit_tuner_test.go:92:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:92
                Error:          Not equal:
                                expected: 1181116006
                                actual  : 858993459
                Test:           TestGlobalMemoryTuner
    memory_limit_tuner_test.go:64:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:64
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/panic.go:522
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/testing.go:871
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:92
                Error:          Should be false
                Test:           TestGlobalMemoryTuner
--- FAIL: TestGlobalMemoryTuner (1.66s)
    memory_limit_tuner_test.go:92:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:92
                Error:          Not equal:
                                expected: 1181116006
                                actual  : 858993459
                Test:           TestGlobalMemoryTuner
    memory_limit_tuner_test.go:64:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:64
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/panic.go:522
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/testing.go:871
                                                        /x/tarball/gctuner/tidb-master/util/gctuner/memory_limit_tuner_test.go:92
                Error:          Should be false
                Test:           TestGlobalMemoryTuner
--- FAIL: TestFinalizer (0.01s)
    finalizer_test.go:40:
                Error Trace:    /x/tarball/gctuner/tidb-master/util/gctuner/finalizer_test.go:40
                Error:          Not equal:
                                expected: 9
                                actual  : 8
                Test:           TestFinalizer

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@hnes hnes added the type/bug The issue is confirmed as a bug. label Feb 10, 2023
@hnes
Copy link
Contributor Author

hnes commented Feb 10, 2023

Refer tikv/pd#5953.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants