-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: cannot generate value for auto_random column if it's in a composite primary key #41454
Labels
affects-5.4
This bug affects 5.4.x versions.
affects-6.1
affects-6.5
affects-6.6
component/lightning
This issue is related to Lightning of TiDB.
severity/critical
type/bug
The issue is confirmed as a bug.
Comments
D3Hunter
changed the title
lightning: cannot generate for auto_random column if it's in a composite primary key
lightning: cannot generate value for auto_random column if it's in a composite primary key
Feb 15, 2023
D3Hunter
added
type/enhancement
The issue or PR belongs to an enhancement.
component/lightning
This issue is related to Lightning of TiDB.
and removed
type/enhancement
The issue or PR belongs to an enhancement.
labels
Feb 15, 2023
12 tasks
ti-chi-bot
added
may-affects-4.0
This bug maybe affects 4.0.x versions.
may-affects-5.0
This bug maybe affects 5.0.x versions.
may-affects-5.1
This bug maybe affects 5.1.x versions.
may-affects-5.2
This bug maybe affects 5.2.x versions.
may-affects-5.3
This bug maybe affects 5.3.x versions.
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.0
may-affects-6.1
may-affects-6.2
may-affects-6.3
may-affects-6.4
may-affects-6.5
may-affects-6.6
labels
Feb 16, 2023
D3Hunter
removed
may-affects-4.0
This bug maybe affects 4.0.x versions.
may-affects-5.1
This bug maybe affects 5.1.x versions.
may-affects-5.2
This bug maybe affects 5.2.x versions.
may-affects-5.3
This bug maybe affects 5.3.x versions.
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-5.0
This bug maybe affects 5.0.x versions.
may-affects-6.0
may-affects-6.1
labels
Feb 16, 2023
D3Hunter
added
affects-5.4
This bug affects 5.4.x versions.
affects-6.1
affects-6.5
affects-6.6
and removed
may-affects-6.2
may-affects-6.3
may-affects-6.4
may-affects-6.5
may-affects-6.6
labels
Feb 16, 2023
ti-chi-bot
pushed a commit
that referenced
this issue
Feb 16, 2023
This was referenced Feb 16, 2023
ti-chi-bot
added a commit
that referenced
this issue
Feb 16, 2023
ti-chi-bot
added a commit
that referenced
this issue
Feb 16, 2023
16 tasks
ti-chi-bot
added a commit
that referenced
this issue
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-5.4
This bug affects 5.4.x versions.
affects-6.1
affects-6.5
affects-6.6
component/lightning
This issue is related to Lightning of TiDB.
severity/critical
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
on tidb 6.5, we can create a table with auto_random column and it's in a composite primary key, while we cannot do it on 6.1
currently lightning check it using pkIsHandle, so will not auto generate data for this column in local backend(tidb backend don't has this problem) if it's the extra column added in downstream but it doesn't exist in source file
tidb/br/pkg/lightning/backend/kv/sql2kv.go
Line 497 in 8497f7d
we should check it with this now
tidb/ddl/ddl_api.go
Line 1552 in 8497f7d
1. Minimal reproduce step (Required)
2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiDB version? (Required)
The text was updated successfully, but these errors were encountered: