Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA RACE TestMultiValuedIndexOnlineDDL #42270

Closed
Tracked by #41316
hawkingrei opened this issue Mar 15, 2023 · 1 comment · Fixed by #42306
Closed
Tracked by #41316

DATA RACE TestMultiValuedIndexOnlineDDL #42270

hawkingrei opened this issue Mar 15, 2023 · 1 comment · Fixed by #42306
Labels
component/test severity/moderate type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

==================
WARNING: DATA RACE
Read at 0x00c0688729f8 by goroutine 501422:
  github.com/pingcap/tidb/sessionctx/variable.(*SessionVars).AllocPlanColumnID()
      sessionctx/variable/session.go:1946 +0x6ca
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:976 +0x691
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Previous write at 0x00c0688729f8 by goroutine 501412:
  github.com/pingcap/tidb/sessionctx/variable.(*SessionVars).AllocPlanColumnID()
      sessionctx/variable/session.go:1946 +0x6ee
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:976 +0x691
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Goroutine 501422 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47

Goroutine 501412 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
==================
==================
WARNING: DATA RACE
Read at 0x00c068873013 by goroutine 501422:
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:986 +0xb4c
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Previous write at 0x00c068873013 by goroutine 501412:
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames.func1()
      expression/expression.go:988 +0x86
  runtime.deferreturn()
      GOROOT/src/runtime/panic.go:476 +0x32
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Goroutine 501422 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47

Goroutine 501412 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
==================
==================
WARNING: DATA RACE
Read at 0x00c068872d68 by goroutine 501422:
  github.com/pingcap/tidb/planner/core.(*PlanBuilder).Init()
      planner/core/planbuilder.go:731 +0x88
  github.com/pingcap/tidb/planner/core.rewriteAstExpr()
      planner/core/expression_rewriter.go:72 +0x193
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:1001 +0xdfa
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Previous write at 0x00c068872d68 by goroutine 501412:
  github.com/pingcap/tidb/planner/core.rewriteAstExpr()
      planner/core/expression_rewriter.go:84 +0x397
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:1001 +0xdfa
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Goroutine 501422 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47

Goroutine 501412 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
==================
==================
WARNING: DATA RACE
Read at 0x00c068873013 by goroutine 501422:
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:986 +0xb4c
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Previous write at 0x00c068873013 by goroutine 501412:
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:990 +0xc2c
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Goroutine 501422 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47

Goroutine 501412 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
==================
==================
WARNING: DATA RACE
Write at 0x00c068873013 by goroutine 501412:
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames.func1()
      expression/expression.go:988 +0x86
  runtime.deferreturn()
      GOROOT/src/runtime/panic.go:476 +0x32
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Previous write at 0x00c068873013 by goroutine 501422:
  github.com/pingcap/tidb/expression.ColumnInfos2ColumnsAndNames()
      expression/expression.go:990 +0xc2c
  github.com/pingcap/tidb/util/admin.makeRowDecoder()
      util/admin/admin.go:196 +0x3b6
  github.com/pingcap/tidb/util/admin.iterRecords()
      util/admin/admin.go:224 +0x6b5
  github.com/pingcap/tidb/util/admin.CheckRecordAndIndex()
      util/admin/admin.go:186 +0x4fd
  github.com/pingcap/tidb/executor.(*CheckTableExec).checkTableRecord()
      executor/executor.go:1097 +0x644
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2.1()
      executor/executor.go:1053 +0x24d
  github.com/pingcap/tidb/util.WithRecovery()
      util/misc.go:96 +0x6d
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next.func2()
      executor/executor.go:1042 +0xc7
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run.func1()
      util/wait_group_wrapper.go:154 +0x73

Goroutine 501412 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47

Goroutine 501422 (running) created at:
  github.com/pingcap/tidb/util.(*WaitGroupWrapper).Run()
      util/wait_group_wrapper.go:152 +0xe4
  github.com/pingcap/tidb/executor.(*CheckTableExec).Next()
      executor/executor.go:1041 +0xa0f
  github.com/pingcap/tidb/executor.Next()
      executor/executor.go:326 +0x326
  github.com/pingcap/tidb/executor.(*ExecStmt).next()
      executor/adapter.go:1212 +0x89
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
      executor/adapter.go:957 +0x4f9
  github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
      executor/adapter.go:782 +0x34a
  github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
      executor/adapter.go:577 +0x129e
  github.com/pingcap/tidb/session.runStmt()
      session/session.go:2333 +0x62f
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2190 +0x10dd
  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()
      testkit/testkit.go:323 +0x8ae
  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()
      testkit/testkit.go:132 +0xb7
  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()
      testkit/testkit.go:127 +0xf7
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:60 +0x550
  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()
      domain/sysvar_cache.go:146 +0x8c4
  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()
      domain/domain.go:1470 +0xa8
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3314 +0x6d3
  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()
      domain/sysvar_cache.go:62 +0x5c
  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()
      session/session.go:3656 +0x104
  github.com/pingcap/tidb/session.(*session).ExecuteStmt()
      session/session.go:2093 +0x145
  github.com/pingcap/tidb/session.(*session).ExecuteInternal()
      session/session.go:1628 +0x31b
  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()
      domain/domain.go:1414 +0x130
  github.com/pingcap/tidb/session.BootstrapSession()
      session/session.go:3307 +0x684
  github.com/pingcap/tidb/testkit.bootstrap()
      testkit/mockstore.go:85 +0xac
  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()
      testkit/mockstore.go:70 +0xe9
  github.com/pingcap/tidb/ddl_test.TestMultiValuedIndexOnlineDDL()
      ddl/mv_index_test.go:29 +0x58
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
==================

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Mar 15, 2023
@zimulala
Copy link
Contributor

Reproduce:
https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_mysql_test/detail/ghpr_mysql_test/17447/pipeline

@zimulala zimulala mentioned this issue Mar 16, 2023
Merged
12 tasks
@hawkingrei hawkingrei mentioned this issue Mar 16, 2023
Open
@xiongjiwei xiongjiwei mentioned this issue Mar 16, 2023
Merged
4 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 16, 2023
@xiongjiwei
test: fix data race (#42306)
4f44dab 
close #42270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/test severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix data race xiongjiwei/tidb
3 participants
@hawkingrei @zimulala @jebter