Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memtrack leak in tpcc test and use too much cpu time #44612

Closed
wshwsh12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #44618
Closed

Memtrack leak in tpcc test and use too much cpu time #44612

wshwsh12 opened this issue Jun 13, 2023 · 0 comments · Fixed by #44618
Labels
affects-6.5 affects-7.1 severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@wshwsh12
Copy link
Contributor

wshwsh12 commented Jun 13, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run https://github.com/pingcap/benchmarksql for a long time.

2. What did you expect to see? (Required)

CPS is stable.

3. What did you see instead (Required)

CPS gradually decreased.
image

There are some memTracker leak, so the Tracker.Detach will use too much cpu time to do memcopy.

image

tidb/executor/prepared.go

Line 114 in 0605903

err = ResetContextOfStmt(e.ctx, stmt0)

Prepare runs ResetContextOfStmt in PrepareExec.Next in binary protocol, but not detach the memory tracker when finished.

4. What is your TiDB version? (Required)

v6.5, v7.1, master
@wshwsh12 wshwsh12 added type/bug The issue is confirmed as a bug. severity/major labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jun 13, 2023
@wshwsh12 wshwsh12 mentioned this issue Jun 13, 2023
Merged
12 tasks
@wshwsh12 wshwsh12 added affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 affects-7.1 labels Jun 13, 2023
@ti-chi-bot ti-chi-bot bot removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-5.2 This bug maybe affects 5.2.x versions. labels Jun 13, 2023
@wshwsh12 wshwsh12 removed affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 labels Jun 13, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jun 13, 2023
@wshwsh12
session: fix the memory tracker leak in prepare binary protocol (#44618)
bb68e2e 
close #44612
This was referenced Jun 13, 2023
Closed
Closed
Closed
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 19, 2023
@ti-chi-bot
session: fix the memory tracker leak in prepare binary protocol (#44618…
af1110c 
…) (#44639)

close #44612
ti-chi-bot bot pushed a commit that referenced this issue Jun 21, 2023
@ti-chi-bot
session: fix the memory tracker leak in prepare binary protocol (#44618…
f5b4ba5 
…) (#44637)

close #44612
@windtalker windtalker mentioned this issue Jul 18, 2023
Merged
17 tasks
@jebter jebter added the sig/execution SIG execution label Oct 17, 2023
XuHuaiyu pushed a commit to XuHuaiyu/tidb that referenced this issue Oct 17, 2023
@wshwsh12 @XuHuaiyu
session: fix the memory tracker leak in prepare binary protocol (ping…
46722ee 
…cap#44618)

close pingcap#44612
@XuHuaiyu XuHuaiyu mentioned this issue Oct 17, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

session: fix the memory tracker leak in prepare binary protocol wshwsh12/tidb
2 participants
@jebter @wshwsh12