Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning disk quota block on check engine size while some engine is importing #44867

Closed
D3Hunter opened this issue Jun 21, 2023 · 0 comments · Fixed by #44877
Closed

lightning disk quota block on check engine size while some engine is importing #44867

D3Hunter opened this issue Jun 21, 2023 · 0 comments · Fixed by #44877
Labels
affects-6.1 affects-6.5 affects-7.1 affects-7.2 component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  • import with disk quota
  • just before disk quota checker tries to getEngineFileSize, some engine lock itself and tries to do import
  • disk quota checker blockes on getEngineFileSize, and other engine keeps writing data into disk, and cause disk used too much
    • in one test, disk_quota=80g, but since quota checker blockes for 34m, the actual disk usage is 2.2T

2. What did you expect to see? (Required)

  • checker keeps running even when some engine start import and ensure disk quota

3. What did you see instead (Required)

  • checker blockes and disk quota exceeded too much.

4. What is your TiDB version? (Required)

current master
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. component/lightning This issue is related to Lightning of TiDB. affects-6.1 affects-6.5 affects-7.1 severity/major labels Jun 21, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Jun 21, 2023
@D3Hunter D3Hunter removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Jun 21, 2023
@D3Hunter D3Hunter mentioned this issue Jun 21, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 21, 2023
@D3Hunter
lightning: fix check disk quota routine block when some engine is imp…
244d9c3 
…orting (#44877)

close #44867
This was referenced Jun 21, 2023
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 21, 2023
@ti-chi-bot
lightning: fix check disk quota routine block when some engine is imp…
3d13b72 
…orting (#44877) (#44879)

close #44867
ti-chi-bot bot pushed a commit that referenced this issue Jun 29, 2023
@ti-chi-bot
lightning: fix check disk quota routine block when some engine is imp…
d52ff9d 
…orting (#44877) (#44881)

close #44867
ti-chi-bot bot pushed a commit that referenced this issue Jun 29, 2023
@ti-chi-bot
lightning: fix check disk quota routine block when some engine is imp…
d68abe5 
…orting (#44877) (#44882)

close #44867
ti-chi-bot bot pushed a commit that referenced this issue Jun 30, 2023
@ti-chi-bot
lightning: fix check disk quota routine block when some engine is imp…
ae39052 
…orting (#44877) (#44880)

close #44867
@niubell niubell mentioned this issue Jul 6, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.5 affects-7.1 affects-7.2 component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: fix check disk quota routine block when some engine is importing pingcap/tidb
1 participant
@D3Hunter