Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: log the reason why the sample-rate is chosen when analyzing table #45936

Closed
qw4990 opened this issue Aug 9, 2023 · 0 comments · Fixed by #45938
Closed

planner: log the reason why the sample-rate is chosen when analyzing table #45936

qw4990 opened this issue Aug 9, 2023 · 0 comments · Fixed by #45938
Labels
affects-7.1 sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Aug 9, 2023

Enhancement

The optimizer chose the wrong sample rate to analyze a big table and then caused TiDB OOM, but now we cannot know why this wrong sample rate is chosen from the log.
It's better to log the reason why the sample rate is chosen for this table when analyzing:
image
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Aug 9, 2023
@qw4990 qw4990 mentioned this issue Aug 9, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 10, 2023
@qw4990
planner: log the reason why the sample-rate is chosen when analyzing …
6fb20c9 
…table (#45938)

close #45936
@ti-chi-bot ti-chi-bot mentioned this issue Aug 10, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 16, 2023
@ti-chi-bot
planner: log the reason why the sample-rate is chosen when analyzing …
6de161e 
…table (#45938) (#45968)

close #45936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.1 sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: log the reason why the sample-rate is chosen when analyzing table qw4990/tidb
1 participant
@qw4990