Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test TestChannelMap #46420

Closed
Tracked by #41316
hawkingrei opened this issue Aug 25, 2023 · 2 comments · Fixed by #46486
Closed
Tracked by #41316

flaky test TestChannelMap #46420

hawkingrei opened this issue Aug 25, 2023 · 2 comments · Fixed by #46486
Labels
component/test severity/moderate type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

=== RUN   TestChannelMap

    misc_test.go:199: channel not closed: blocked

--- FAIL: TestChannelMap (0.00s)

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Aug 25, 2023
@hawkingrei hawkingrei mentioned this issue Aug 25, 2023
Open
@gonnafaraway
Copy link

image
Hi!
Tested locally, got no errors, how can i reproduce this problem?
@hawkingrei

@jiyfhust
Copy link
Contributor

jiyfhust commented Aug 30, 2023 •
edited
Loading

There seems to be goroutine competition here:

https://github.com/pingcap/tidb/blob/a631d2ff2e8f29ddadfbdee106805d1c8b3e99cb/util/util.go#L94C13-L94C13

tidb/util/misc_test.go

Line 196 in a631d2f

case item, ok := <-ch:

@jiyfhust jiyfhust mentioned this issue Aug 30, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 30, 2023
@jiyfhust
test: fix test TestChannelMap (#46486)
d1483b8 
close #46420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/test severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test TestChannelMap jiyfhust/tidb
3 participants
@hawkingrei @jiyfhust @gonnafaraway