-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the log level and returned value when cacheableChecker
check *ast.TableName
nodes
#46760
Labels
affects-6.5
affects-7.1
epic/plan-cache
severity/minor
sig/planner
SIG: Planner
type/bug
The issue is confirmed as a bug.
Comments
zimulala
added
type/bug
The issue is confirmed as a bug.
sig/planner
SIG: Planner
severity/minor
affects-6.5
labels
Sep 7, 2023
zimulala
changed the title
Adjust the log level and supplement log when
Adjust the log level and returned value when Sep 7, 2023
cacheableChecker
check *ast.TableName
nodescacheableChecker
check *ast.TableName
nodes
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
affects-7.1
epic/plan-cache
severity/minor
sig/planner
SIG: Planner
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
TableByName
encounters an error, we need to adjust the log level and supplement the error log. Because this error does not affect execution results.tidb/planner/core/plan_cacheable_checker.go
Lines 557 to 609 in 41d1ec0
TableByName
, I think it makes sense to return true2. What did you expect to see? (Required)
Change this log to a warning and add some info to check the cause of this error later.
3. What did you see instead (Required)
logutil.BgLogger().Error("Error occur in checking cacheable", zap.Error(err))
4. What is your TiDB version? (Required)
Release Version: v7.4.0-alpha-292-g5cbcc86e50
Edition: Community
Git Commit Hash: 5cbcc86
The text was updated successfully, but these errors were encountered: