Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: remove noisy logs for stale read #47308

Closed
cfzjywxk opened this issue Sep 27, 2023 · 0 comments · Fixed by #47309
Closed

util: remove noisy logs for stale read #47308

cfzjywxk opened this issue Sep 27, 2023 · 0 comments · Fixed by #47309
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@cfzjywxk
Copy link
Contributor

Enhancement

Many noisy logs are printed when stale read is used

[2023/09/22 22:58:36.055 +00:00] [WARN] [builtin_time.go:6639] [calAppropriateTime] [minTime=2023/09/22 22:57:36.055 +00:00] [maxTime=2023/09/22 22:58:36.055 +00:00] [minSafeTime=2023/09/22 22:57:35.289 +00:00]

It should not be printed as WARN log level
@cfzjywxk cfzjywxk added the type/enhancement The issue or PR belongs to an enhancement. label Sep 27, 2023
This was referenced Sep 27, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 8, 2023
@cfzjywxk
util: change log level to debug calculating stale read ts (#47309)
a98a02c 
close #47308
This was referenced Oct 8, 2023
Merged
Merged
@cfzjywxk cfzjywxk added type/bug The issue is confirmed as a bug. severity/major and removed type/enhancement The issue or PR belongs to an enhancement. labels Oct 8, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Oct 8, 2023
@cfzjywxk cfzjywxk added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. sig/transaction SIG:Transaction and removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Oct 8, 2023
ti-chi-bot bot pushed a commit that referenced this issue Oct 8, 2023
@ti-chi-bot
util: change log level to debug calculating stale read ts (#47309) (#…
f114d1c 
…47453)

close #47308
ti-chi-bot bot pushed a commit that referenced this issue Oct 18, 2023
@ti-chi-bot
util: change log level to debug calculating stale read ts (#47309) (#…
60b4dcc 
…47452)

close #47308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: change log level to debug calculating stale read ts cfzjywxk/tidb
1 participant
@cfzjywxk