Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local backend: worker error is eaten on some case #47781

Closed
D3Hunter opened this issue Oct 19, 2023 · 0 comments · Fixed by #47782
Closed

local backend: worker error is eaten on some case #47781

D3Hunter opened this issue Oct 19, 2023 · 0 comments · Fixed by #47782
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

suppose when execute job we return the remaining storage capacity of TiKV(%s) is less than 10%%, the context will be cancelled

for i := 0; i < local.WorkerConcurrency; i++ {
workGroup.Go(func() error {
return local.startWorker(workerCtx, jobToWorkerCh, jobFromWorkerCh, &jobWg)
})
}

then here we noticed that context cancelled and return context cancelled error(might be wrapped inside other error, such as rpc error: code = Canceled desc = context canceled: [BR:PD:ErrPDBatchScanRegion]batch scan region" during page scan regions)

err := local.prepareAndSendJob(

and in here, we record this context cancelled err, not the err that causes context cancel is eaten
if err != nil {
firstErr.Set(err)
workerCancel()
_ = workGroup.Wait()
return firstErr.Get()
}

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants