-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: lock error is not handled getting commit ts of schema diff key #48281
Labels
affects-6.5
affects-7.1
affects-7.5
severity/major
sig/sql-infra
SIG: SQL Infra
sig/transaction
SIG:Transaction
type/bug
The issue is confirmed as a bug.
Comments
cfzjywxk
added
type/bug
The issue is confirmed as a bug.
sig/transaction
SIG:Transaction
sig/sql-infra
SIG: SQL Infra
severity/major
affects-6.5
affects-7.1
affects-7.5
labels
Nov 3, 2023
ti-chi-bot
bot
added
may-affects-5.3
This bug maybe affects 5.3.x versions.
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
labels
Nov 3, 2023
cfzjywxk
removed
may-affects-5.3
This bug maybe affects 5.3.x versions.
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.1
labels
Nov 3, 2023
This was referenced Nov 3, 2023
cfzjywxk
changed the title
domain: lock error is not handled getting commit ts of schema version
domain: lock error is not handled getting commit ts of schema diff key
Nov 3, 2023
This was referenced Nov 6, 2023
This was referenced Nov 8, 2023
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
affects-7.1
affects-7.5
severity/major
sig/sql-infra
SIG: SQL Infra
sig/transaction
SIG:Transaction
type/bug
The issue is confirmed as a bug.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
Running stale read with concurrent DDL statements.
The cause of this issue is that the
mvccGetResp
may containWrite
information orLock
information when there's a perwrite lock on the key. In this situation, it's needed to resolve the lock to get the actualcommit_ts
of the schema version. Currently, it's not handled so even though the internal transaction has been committed the mvcc get may return nothing reading the schema diff key.2. What did you expect to see? (Required)
The stale read should use schema versions from schema cache.
3. What did you see instead (Required)
Sometimes the schema cache would be invalidated because of
mvcc get
error when getting commit ts of schema version.Related debug logs
4. What is your TiDB version? (Required)
v6.5.4
The text was updated successfully, but these errors were encountered: