Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100T global sort on GCS is slow due to checking old BR object hierarchy #50533

Closed
lance6716 opened this issue Jan 18, 2024 · 2 comments · Fixed by #50534
Closed

100T global sort on GCS is slow due to checking old BR object hierarchy #50533

lance6716 opened this issue Jan 18, 2024 · 2 comments · Fixed by #50534
Labels
affects-6.1 affects-6.5 affects-7.1 affects-7.5 affects-7.6 component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

At the beginning of the ingest step
image
image

Don't know how long it will last
@lance6716 lance6716 added the type/bug The issue is confirmed as a bug. label Jan 18, 2024
@lance6716 lance6716 mentioned this issue Jan 18, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 18, 2024
@lance6716
external: remove old compatibility check of BR (#50534)
c92094f 
close #50533
@ti-chi-bot ti-chi-bot mentioned this issue Jan 18, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 18, 2024
@ti-chi-bot
external: remove old compatibility check of BR (#50534) (#50537)
c2ff297 
close #50533
@kennytm kennytm added the component/br This issue is related to BR of TiDB. label Feb 27, 2024
@kennytm
Copy link
Contributor

kennytm commented Feb 27, 2024

This check was created to fix pingcap/br#675 for BR v4.0.8. Given our compatibility strategy I think #50534 can be cherry-picked to v6.x.x the earliest?

We've got an issue where the customer using TiCDC v7.5 with GCS as redo log storage got a DeadlineExceeded error because this check takes over 5 minutes in total.

This was referenced Feb 27, 2024
Merged
Merged
Merged
Open
@lance6716
Copy link
Contributor Author

@kennytm I have created the cherry-pick PRs. Please notify the cherry-pick triage role of TiCDC to approve them.

ti-chi-bot bot pushed a commit that referenced this issue Feb 28, 2024
@ti-chi-bot
external: remove old compatibility check of BR (#50534) (#51338)
a81d27e 
close #50533
ti-chi-bot bot pushed a commit that referenced this issue Mar 25, 2024
@ti-chi-bot
external: remove old compatibility check of BR (#50534) (#51339)
a3bc52c 
close #50533
ti-chi-bot bot pushed a commit that referenced this issue May 21, 2024
@ti-chi-bot
external: remove old compatibility check of BR (#50534) (#51340)
5989364 
close #50533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.5 affects-7.1 affects-7.5 affects-7.6 component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

external: remove old compatibility check of BR lance6716/tidb
3 participants
@kennytm @lance6716 @CharlesCheung96