-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge lightning preprocess duplicate detection and post-import conflict detection #51036
Labels
Comments
/assign @lyzx2001 |
13 tasks
This was referenced Feb 23, 2024
17 tasks
13 tasks
This was referenced Mar 19, 2024
13 tasks
Further optimization will be tracked by #52306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement
Merge lightning preprocess duplicate detection and post-import conflict detection
We remove the old configuration options, including record and remove, which are less useful and confusing for users.
tikv-importer.duplicate-resolutionwill not be used after preprocess duplicate detection and post-import conflict detection are merged.
Add a parameter
conflict.precheck-conflict-before-import
to control whether to turn on preprocess duplicate detection. The valid value istrue
andfalse
, and the default isfalse
.Users should be able to check table
lightning_task_info.conflict_error_v2
for all the conflicts, including conflicts from both preprocess duplicate detection and post-import conflict detection. Previously, conflicts from preprocess duplicate detection were stored in tablelightning_task_info.conflict_records
, so here we need to integrate them intolightning_task_info.conflict_error_v2
.Pre-work: Support
replace
mode for lightning post-import conflict detection #45774The text was updated successfully, but these errors were encountered: