Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pitr: support log backup to s3 when object lock is enabled #51184

Closed
BornChanger opened this issue Feb 20, 2024 · 3 comments · Fixed by #51210
Closed

pitr: support log backup to s3 when object lock is enabled #51184

BornChanger opened this issue Feb 20, 2024 · 3 comments · Fixed by #51210
Labels
component/br This issue is related to BR of TiDB. severity/major type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@BornChanger
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Currently, full backup supports s3 object lock but log backup does not.

Describe the feature you'd like:

We need to also enable object lock support for log backup.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:
@BornChanger BornChanger added the type/feature-request Categorizes issue or PR as related to a new feature. label Feb 20, 2024
@BornChanger
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Feb 20, 2024
@BornChanger
Copy link
Contributor Author

/severity major

@RidRisR
Copy link
Contributor

RidRisR commented Feb 21, 2024 •
edited
Loading

Note: Only enable Object Lock will not trigger this problem. There is no special requirement for Object Lock.
Instead it is the option retention time that requires a header of content-MD5. See https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html

@RidRisR RidRisR mentioned this issue Feb 21, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 28, 2024
@RidRisR
pitr: support log backup to s3 when object lock is enabled (#51210)
c23f0c9 
close #51184
@RidRisR RidRisR mentioned this issue Mar 12, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. severity/major type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
2 participants
@RidRisR @BornChanger