Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreCalculateScalar consumes a lot of CPU when non-lite init stats #52343

Closed
winoros opened this issue Apr 3, 2024 · 1 comment · Fixed by #52623
Closed

PreCalculateScalar consumes a lot of CPU when non-lite init stats #52343

winoros opened this issue Apr 3, 2024 · 1 comment · Fixed by #52623
Labels
affects-8.1 sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@winoros
Copy link
Member

winoros commented Apr 3, 2024

Enhancement

image

After #52342 is fixed, we found another CPU consumer.
Too many small obj are allocated and causing too much GC pressure.
@winoros winoros added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Apr 3, 2024
@winoros
Copy link
Member Author

winoros commented Apr 3, 2024

And it's also a possible issue when we load needed histograms.

@winoros winoros mentioned this issue Apr 15, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 16, 2024
@winoros
statistics: reduce small obj alloc for PreCalculateScalar (#52623)
e5863e1 
close #52343
@ti-chi-bot ti-chi-bot mentioned this issue Apr 16, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 17, 2024
@ti-chi-bot
statistics: reduce small obj alloc for PreCalculateScalar (#52623) (#…
c69f844 
…52652)

close #52343
@hawkingrei hawkingrei mentioned this issue Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.1 sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: reduce small obj alloc for PreCalculateScalar winoros/tidb
2 participants
@winoros @ti-chi-bot