Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use a whole *StatementContext as RangeFallbackHandler #52737

Closed
YangKeao opened this issue Apr 18, 2024 · 0 comments · Fixed by #52738
Closed

Don't use a whole *StatementContext as RangeFallbackHandler #52737

YangKeao opened this issue Apr 18, 2024 · 0 comments · Fixed by #52738
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

YangKeao commented Apr 18, 2024 •
edited
Loading

Enhancement

We left a TODO for RangeFallbackHandler, because we are using a whole *StatementContext as the implementation of RangeFallbackHandler. We can extract some fields out of the statement context, and create a smaller implementation of RangeFallbackHandler.
@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Apr 18, 2024
@YangKeao YangKeao changed the title Don Don't use a whole *StatementContext as RangeFallbackHandler Apr 18, 2024
@YangKeao YangKeao mentioned this issue Apr 18, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 22, 2024
@YangKeao
stmtctx: use a standalone RangeFallbackHandler (#52738)
cfbabfa 
close #52737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stmtctx: use a standalone RangeFallbackHandler YangKeao/tidb
1 participant
@YangKeao