Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add index rollback when tidb rolling restart #52805

Closed
Lily2025 opened this issue Apr 22, 2024 · 1 comment · Fixed by #53134 · May be fixed by #52808
Closed

add index rollback when tidb rolling restart #52805

Lily2025 opened this issue Apr 22, 2024 · 1 comment · Fixed by #53134 · May be fixed by #52808
Assignees
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@Lily2025
Copy link

Lily2025 commented Apr 22, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

1、with tidb_enable_dist_task='off'
2、run sysbench
3、add index for one of table
4、tidb rolling restart

logs:
tidb-0.tar.gz
tidb-1.tar.gz

2. What did you expect to see? (Required)

add index can success

3. What did you see instead (Required)

add index rollback when tidb rolling restart

the status of ddl job is not synced or done or running or queueing (now: 2024-04-20 07:12:03, jobId: 586, job type: add index /* ingest /, state: rollback done)
operatorLogs:
[2024-04-20 07:08:32] ###### start adding index
ALTER TABLE sbtest1 ADD INDEX index_test_1713568112880(c)
[2024-04-20 07:08:32] ###### wait for ddl job finish
[2024-04-20 07:12:03] ###### wait for ddl job to finish failed
select job_id, job_type, state from information_schema.ddl_jobs where query = 'ALTER TABLE sbtest1 ADD INDEX index_test_1713568112880(c)'
jobId: 586, job type: add index /
ingest */, state: rollback done

4. What is your TiDB version? (Required)

./tidb-server -V
Release Version: v7.1.5
Edition: Community
Git Commit Hash: f4faa50
Git Branch: HEAD
UTC Build Time: 2024-04-19 10:49:04
GoVersion: go1.20.10
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: unistore
2024-04-20T07:08:24.815+0800

@Lily2025 Lily2025 added the type/bug The issue is confirmed as a bug. label Apr 22, 2024
@Lily2025
Copy link
Author

/assign tangenta
/severity major

@tangenta tangenta added affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 labels Apr 22, 2024
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label Apr 25, 2024
ti-chi-bot bot pushed a commit that referenced this issue May 13, 2024
terry1purcell pushed a commit to terry1purcell/tidb that referenced this issue May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
3 participants