Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Backup being paused due to a false positive in the automatic lag check. #53561

Closed
3pointer opened this issue May 27, 2024 · 2 comments · Fixed by #53695
Closed

Log Backup being paused due to a false positive in the automatic lag check. #53561

3pointer opened this issue May 27, 2024 · 2 comments · Fixed by #53695
Labels
affects-6.5 affects-7.1 affects-7.5 affects-8.1 component/br This issue is related to BR of TiDB. report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.

Comments

@3pointer
Copy link
Contributor

3pointer commented May 27, 2024 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. start a log backup
  2. wait for 48h(the default lag check threshold)
  3. restart tidb advancer(or other scenarios that make advancer owner changed)

2. What did you expect to see? (Required)

a normal log backup status.

3. What did you see instead (Required)

log backup paused by chance.

(The chance is the lastCheckpoint cannot be updated in time before checking. e.g. regions has a hole will make lastCheckpoint skip update this time and wait for next tick. )

4. What is your TiDB version? (Required)

v6.5.9/v7.1.5/v8.1.0/master
@3pointer 3pointer added type/bug The issue is confirmed as a bug. component/br This issue is related to BR of TiDB. affects-6.5 affects-8.1 affects-7.1 labels May 27, 2024
@RidRisR RidRisR mentioned this issue May 31, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.5 labels Jun 5, 2024
@BornChanger BornChanger removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.5 labels Jun 5, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jun 11, 2024
@RidRisR
br: fix Log Backup unexpected paused when adding a already long-runni…
64f5427 
…ng task (#53695)

close #53561
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 12, 2024
@ti-chi-bot
br: fix Log Backup unexpected paused when adding a already long-runni…
366ed7d 
…ng task (#53695) (#53947)

close #53561
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jul 5, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jul 5, 2024
@ti-chi-bot
br: fix Log Backup unexpected paused when adding a already long-runni…
0f0ce24 
…ng task (#53695) (#53946)

close #53561
ti-chi-bot bot pushed a commit that referenced this issue Jul 18, 2024
@ti-chi-bot
br: fix Log Backup unexpected paused when adding a already long-runni…
1e48813 
…ng task (#53695) (#53948)

close #53561
ti-chi-bot bot pushed a commit that referenced this issue Jul 18, 2024
@ti-chi-bot
br: fix Log Backup unexpected paused when adding a already long-runni…
431781f 
…ng task (#53695) (#53945)

close #53561
@3pointer
Copy link
Contributor Author

this issue was introduced in #50803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-7.1 affects-7.5 affects-8.1 component/br This issue is related to BR of TiDB. report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: fix Log Backup unexpected paused when adding a already long-running task RidRisR/tidb
4 participants
@3pointer @Leavrth @seiya-annie @BornChanger