Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client leak or directory locked when met error when creating local backend #53659

Closed
D3Hunter opened this issue May 29, 2024 · 0 comments · Fixed by #53664
Closed

client leak or directory locked when met error when creating local backend #53659

D3Hunter opened this issue May 29, 2024 · 0 comments · Fixed by #53664
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

for example, if we got error in below code, such as context cancel, and we are using de-duplicate, all clients are leak and duplicated directory is locked

if err = local.checkMultiIngestSupport(ctx); err != nil {
return nil, common.ErrCheckMultiIngest.Wrap(err).GenWithStackByArgs()
}

it's not a big issue for lightning, but for import-into, it's run in a long running process, might cause issue.

2. What did you expect to see? (Required)

cleaned up on fail

3. What did you see instead (Required)

leaked and directory locked

4. What is your TiDB version? (Required)

master

@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. severity/major affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels May 29, 2024
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants