Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logical cpu number as the default value of fine grained stream count #55543

Closed
windtalker opened this issue Aug 21, 2024 · 0 comments · Fixed by #55544
Closed

Use logical cpu number as the default value of fine grained stream count #55543

windtalker opened this issue Aug 21, 2024 · 0 comments · Fixed by #55544
Assignees
@windtalker
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@windtalker
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!
Currently, TiDB use physical cpu cores as the default value of fine grained stream count, this is due to TiFlash used to use physical cpu cores as its default max_threads.
From v7.5.0, TiFlash use logical cpu cores as the default value of max_threads, TiDB should update the default fine grained stream count to logical cpu cores as well

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@windtalker windtalker added type/bug The issue is confirmed as a bug. sig/execution SIG execution severity/major labels Aug 21, 2024
@windtalker windtalker self-assigned this Aug 21, 2024
@windtalker windtalker added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Aug 21, 2024
@windtalker windtalker mentioned this issue Aug 21, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 38f9d70 Aug 21, 2024
This was referenced Aug 22, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Aug 22, 2024
@ti-chi-bot
planner: use logical cores as default fine grained stream count (#55544…
ee13c7b 
…) (#55576)

close #55543
ti-chi-bot bot pushed a commit that referenced this issue Aug 27, 2024
@ti-chi-bot
planner: use logical cores as default fine grained stream count (#55544…
e0699a6 
…) (#55575)

close #55543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@windtalker windtalker

Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: use logical cores as default fine grained stream count windtalker/tidb
1 participant
@windtalker