Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal session cannot parse SQLs containing window functions #55981

Closed
kaixu120811 opened this issue Sep 10, 2024 · 2 comments · Fixed by #55991
Closed

Internal session cannot parse SQLs containing window functions #55981

kaixu120811 opened this issue Sep 10, 2024 · 2 comments · Fixed by #55991
Assignees
@hawkingrei
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@kaixu120811
Copy link
Collaborator

kaixu120811 commented Sep 10, 2024 •
edited by winoros
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

A clean cluster.
Create a binding for an SQL containing window function.
Shutdown and reboot the TiDB

2. What did you expect to see? (Required)

The binding is loaded correctly.

3. What did you see instead (Required)

No binding is read to TiDB's memory.

4. What is your TiDB version? (Required)

Version 6.5.7
@kaixu120811 kaixu120811 added the type/bug The issue is confirmed as a bug. label Sep 10, 2024
@jackysp jackysp added the sig/planner SIG: Planner label Sep 10, 2024
@kaixu120811
Copy link
Collaborator Author

For someone who will be the owner of this bug fix, please contact Damon to get some information about bug repro.

@hawkingrei hawkingrei self-assigned this Sep 10, 2024
@jebter jebter added the affects-6.5 This bug affects the 6.5.x(LTS) versions. label Sep 10, 2024
@winoros winoros changed the title The binding information won't be synced to every tidb server of TiDB cluster when it's set by mysql client. Internal session cannot parse SQLs containing window functions Sep 10, 2024
@winoros winoros mentioned this issue Sep 10, 2024
Merged
13 tasks
@winoros winoros added severity/major affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Sep 10, 2024
@hawkingrei hawkingrei removed the may-affects-5.4 This bug maybe affects 5.4.x versions. label Sep 10, 2024
@winoros winoros added the affects-6.1 This bug affects the 6.1.x(LTS) versions. label Sep 10, 2024
This was referenced Sep 10, 2024
Merged
Merged
Open
@winoros
Copy link
Member

winoros commented Sep 10, 2024

6.1 6.5 7.1 7.5 will have a problem with loading the binding.
8.1 and master is fine with binding. But still doesn't set the EnableWindowFunction correctly for some internal session.

ti-chi-bot bot pushed a commit that referenced this issue Sep 10, 2024
@winoros
session: set EnableWindowFunction for all SessionVars (#55991) (#55992)
1097ba8 
ref #55981
@ti-chi-bot ti-chi-bot bot closed this as completed in 2c30f86 Sep 10, 2024
This was referenced Sep 10, 2024
Closed
Closed
Closed
Merged
Open
ti-chi-bot bot pushed a commit that referenced this issue Sep 11, 2024
@winoros
session: set EnableWindowFunction for all SessionVars (#55991) (#55993)
f9c1dd1 
ref #55981
Benjamin2037 pushed a commit to Benjamin2037/tidb that referenced this issue Sep 11, 2024
@winoros @Benjamin2037
session: set EnableWindowFunction for all SessionVars (pingcap#55991)
194f501 
close pingcap#55981
ti-chi-bot bot pushed a commit that referenced this issue Sep 27, 2024
@ti-chi-bot
session: set EnableWindowFunction for all SessionVars (#55991) (#55999)
e61d6dd 
close #55981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkingrei hawkingrei

Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

session: set EnableWindowFunction for all SessionVars winoros/tidb
5 participants
@hawkingrei @jackysp @jebter @winoros @kaixu120811