Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test TestTetchAllSchemasWithTablesWithFailpoint #56851

Closed
bb7133 opened this issue Oct 25, 2024 · 2 comments · Fixed by #57433
Closed

Flaky test TestTetchAllSchemasWithTablesWithFailpoint #56851

bb7133 opened this issue Oct 25, 2024 · 2 comments · Fixed by #57433
Assignees
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@bb7133
Copy link
Member

bb7133 commented Oct 25, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Found in release-8.4 branch(https://do.pingcap.net/jenkins/blue/rest/organizations/jenkins/pipelines/pingcap/pipelines/tidb/pipelines/release-8.4/pipelines/pull_unit_test/runs/34/nodes/63/steps/69/log/?start=0):

[2024/10/25 16:44:40.960 +00:00] [ERROR] [domain.go:1095] ["reload schema in loop failed"] [error="failpoint: failed to fetch schemas with tables"] [errorVerbose="failpoint: failed to fetch schemas with tables\ngithub.com/pingcap/tidb/pkg/domain.(*Domain).fetchSchemasWithTables\n\tpkg/domain/domain.go:507\ngithub.com/pingcap/tidb/pkg/domain.(*Domain).fetchAllSchemasWithTables.func1\n\tpkg/domain/domain.go:471\ngithub.com/pingcap/tidb/pkg/util.(*ErrorGroupWithRecover).Go.func1\n\tpkg/util/wait_group_wrapper.go:250\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\texternal/org_golang_x_sync/errgroup/errgroup.go:78\nruntime.goexit\n\tsrc/runtime/asm_amd64.s:1700"] [stack="github.com/pingcap/tidb/pkg/domain.(*Domain).loadSchemaInLoop\n\tpkg/domain/domain.go:1095\ngithub.com/pingcap/tidb/pkg/domain.(*Domain).Start.func2\n\tpkg/domain/domain.go:1490\ngithub.com/pingcap/tidb/pkg/util.(*WaitGroupEnhancedWrapper).Run.func1\n\tpkg/util/wait_group_wrapper.go:99"]
    db_test.go:202: 
        	Error Trace:	pkg/domain/db_test.go:202
        	Error:      	An error is expected but got nil.
        	Test:       	TestTetchAllSchemasWithTablesWithFailpoint

I'm not sure if master has this, too.

And there's a typo in TestTetchAllSchemasWithTablesWithFailpoint, which should be fixed, too.

@bb7133 bb7133 added the type/bug The issue is confirmed as a bug. label Oct 25, 2024
@bb7133
Copy link
Member Author

bb7133 commented Oct 25, 2024

PTAL @joccau

@jebter jebter added component/test severity/major component/ddl This issue is related to DDL of TiDB. labels Oct 29, 2024
@ti-chi-bot ti-chi-bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Nov 1, 2024
@joccau joccau mentioned this issue Nov 16, 2024
13 tasks
@joccau
Copy link
Member

joccau commented Nov 16, 2024

/remove-label may-affects-5.4
/remove-label may-affects-6.1
/remove-label may-affects-6.5
/remove-label may-affects-7.1
/remove-label may-affects-7.5
/remove-label may-affects-8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants