Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix unstable case #57433

Merged
merged 1 commit into from
Nov 18, 2024
Merged

test: fix unstable case #57433

merged 1 commit into from
Nov 18, 2024

Conversation

joccau
Copy link
Member

@joccau joccau commented Nov 16, 2024

What problem does this PR solve?

Issue Number: close #56851

Problem Summary:

What changed and how does it work?

  • Fix unstable case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: joccau <zak.zhao@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Nov 16, 2024
@joccau joccau changed the title fix unstable case test: fix unstable case Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7726%. Comparing base (4a6bf46) to head (1bb1171).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57433        +/-   ##
================================================
+ Coverage   72.8367%   74.7726%   +1.9358%     
================================================
  Files          1672       1717        +45     
  Lines        462640     470941      +8301     
================================================
+ Hits         336972     352135     +15163     
+ Misses       104878      96725      -8153     
- Partials      20790      22081      +1291     
Flag Coverage Δ
integration 49.1870% <ø> (?)
unit 72.2954% <ø> (+0.0804%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.7399% <ø> (+15.6358%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 16, 2024
@hawkingrei hawkingrei requested a review from tangenta November 16, 2024 10:56
Copy link

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 18, 2024
Copy link

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-16 10:56:54.037552456 +0000 UTC m=+699376.228421438: ☑️ agreed by hawkingrei.
  • 2024-11-18 03:47:50.85412728 +0000 UTC m=+846433.044996278: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 3232160 into pingcap:master Nov 18, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test TestTetchAllSchemasWithTablesWithFailpoint
3 participants