Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sync load Monitoring to Include P9999 Latency #56980

Closed
hawkingrei opened this issue Oct 30, 2024 · 0 comments · Fixed by #56981
Closed

Improve sync load Monitoring to Include P9999 Latency #56980

hawkingrei opened this issue Oct 30, 2024 · 0 comments · Fixed by #56981
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

Enhancement

The current sync load monitoring primarily focuses on P95 latency, which is insufficient for capturing extreme timeout issues. While P95 latency may not indicate a timeout, P9999 latency could be significantly high, leading to potential misjudgments and overlooked performance issues.
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Oct 30, 2024
@hawkingrei hawkingrei mentioned this issue Oct 30, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 7ed2ad7 Oct 30, 2024
This was referenced Oct 30, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot bot added affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Oct 30, 2024
ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2024
@ti-chi-bot
metrics: set sync load latency as P9999 (#56981) (#57000)
e1ae550 
close #56980
ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2024
@ti-chi-bot
metrics: set sync load latency as P9999 (#56981) (#57001)
4d008bd 
close #56980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: set sync load latency as P9999 hawkingrei/tidb
1 participant
@hawkingrei