Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb_scatter_region variable should supports setting values in both upper/lower case #57669

Closed
River2000i opened this issue Nov 25, 2024 · 3 comments · Fixed by #57677
Closed
Labels
affects-8.4 affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@River2000i
Copy link
Contributor

River2000i commented Nov 25, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

mysql> set global tidb_scatter_region = "table";
Query OK, 0 rows affected (0.01 sec)

mysql> set global tidb_scatter_region = "TABLE";
ERROR 1105 (HY000): invalid value for 'TABLE', it should be either '', 'table' or 'global'
mysql> set global tidb_scatter_region = "global";
Query OK, 0 rows affected (0.01 sec)

mysql> set global tidb_scatter_region = "GLOBAL";
ERROR 1105 (HY000): invalid value for 'GLOBAL', it should be either '', 'table' or 'global'
mysql> select @@tidb_scatter_region;
+-----------------------+
| @@tidb_scatter_region |
+-----------------------+
|                       |
+-----------------------+
1 row in set (0.00 sec)

mysql> set session tidb_scatter_region = "GLOBAL";
ERROR 1105 (HY000): invalid value for 'GLOBAL', it should be either '', 'table' or 'global'
mysql> set session tidb_scatter_region = "global";
Query OK, 0 rows affected (0.00 sec)

mysql> select @@tidb_scatter_region;
+-----------------------+
| @@tidb_scatter_region |
+-----------------------+
| global                |
+-----------------------+
1 row in set (0.00 sec)

mysql>

2. What did you expect to see? (Required)

tidb_scatter_region should support setting values by uppercase

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

mysql> select tidb_version();
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                        |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v8.5.0-alpha-32-g1961f5e67c
Edition: Community
Git Commit Hash: 1961f5e67cf92262b594c9b90fb3aa62aa80cb72
Git Branch: HEAD
UTC Build Time: 2024-11-04 04:00:54
GoVersion: go1.23.2
Race Enabled: false
Check Table Before Drop: false
Store: unistore |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql>
@River2000i
Copy link
Contributor Author

River2000i commented Nov 25, 2024

/label affects-8.4
/label affects-8.5

@ti-chi-bot ti-chi-bot bot added affects-8.4 affects-8.5 This bug affects the 8.5.x(LTS) versions. labels Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 25, 2024

@River2000i: The label(s) severity/minor cannot be applied. These labels are supported: fuzz/sqlancer, challenge-program, compatibility-breaker, first-time-contributor, contribution, good first issue, correctness, duplicate, proposal, security, needs-more-info, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.5, needs-cherry-pick-release-7.1, needs-cherry-pick-release-7.5, needs-cherry-pick-release-8.1, needs-cherry-pick-release-8.5, affects-5.4, affects-6.1, affects-6.5, affects-7.1, affects-7.5, affects-8.1, affects-8.4, affects-8.5, may-affects-5.4, may-affects-6.1, may-affects-6.5, may-affects-7.1, may-affects-7.5, may-affects-8.1, may-affects-8.5.

In response to this:

/label affects-8.4
/label affects-8.5

/label severity/minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@River2000i
Copy link
Contributor Author

/severity minor

@River2000i River2000i changed the title tidb_scatter_region variable supports setting values in both upper/lower case tidb_scatter_region variable should supports setting values in both upper/lower case Nov 25, 2024
@jebter jebter added the component/ddl This issue is related to DDL of TiDB. label Nov 26, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in dcc9dcc Nov 26, 2024
ti-chi-bot bot pushed a commit that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.4 affects-8.5 This bug affects the 8.5.x(LTS) versions. component/ddl This issue is related to DDL of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants