-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast function should not fail. #645
Labels
type/bug
The issue is confirmed as a bug.
Comments
I think we should use error for type cast, like |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this issue
Apr 23, 2021
* refactor ingester * adapt ingester * fmt & add some comments * fix hound * fix hound * fix * fix ci * fix test * fix test * fix ci * fix lint * fix lint * fix index panic * sleep more time to wait ticdc synced * address comment * address comment * fix test * fix resolve lock * fix hound * fix nextkey * fix hound * fix lint * fix ci * refactor log * fix deadlock * change concurrency config * fix hound * fix remain range * fix hound * fix sort bug * fix infinte loop * fix test: resolve ts is 0 * update ingester coverage * add seek for iterator & add some unit test * address comment * remove concurrency iter * fix * fix lost * change range to [start, end) * add iter producer * fix build * remove iter's lock * fix build * Update pkg/kv/kv.go Co-authored-by: glorv <glorvs@163.com> * address comment * Update pkg/kv/kv.go Co-authored-by: glorv <glorvs@163.com> * address comment * Update pkg/kv/kv.go Co-authored-by: kennytm <kennytm@gmail.com> * Update pkg/restore/split_client.go Co-authored-by: kennytm <kennytm@gmail.com> * adapt logutil * address comment * fix iter.Next() * fix build Co-authored-by: glorv <glorvs@163.com> Co-authored-by: kennytm <kennytm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
select cast("-1" as UNSIGNED)
should return18446744073709551615
, but we get "constant -1 overflows bigint" error.This is because we use
Convert
function for cast, but actuallycast
works differently thanconvert
.cast("xxx" as DATETIME)
should returns NULL, butConvert
such an invalid time string returns zero time.The text was updated successfully, but these errors were encountered: