-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan, privilege: add role support for SHOW GRANT
#10016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
sig/planner
SIG: Planner
sig/execution
SIG execution
component/privilege
type/TEP
labels
Apr 3, 2019
parser pr: pingcap/parser#272 |
/run-all-tests |
tiancaiamao
reviewed
Apr 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #10016 +/- ##
================================================
+ Coverage 77.9584% 77.9736% +0.0152%
================================================
Files 407 407
Lines 83075 83146 +71
================================================
+ Hits 64764 64832 +68
Misses 13516 13516
- Partials 4795 4798 +3 |
jackysp
reviewed
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @tiancaiamao
LGTM |
imtbkcat
force-pushed
the
showgrant
branch
2 times, most recently
from
April 18, 2019 07:29
20f74c9
to
41483ca
Compare
/run-all-tests |
PTAL @tiancaiamao |
tiancaiamao
approved these changes
Apr 21, 2019
/run-code_coverage |
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/privilege
sig/execution
SIG execution
sig/planner
SIG: Planner
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
SHOW GRANT
.SHOW GRANT USING roles
What is changed and how it works?
Roles
field forShowStmt
,ShowExec
.SHOW GRANT
, reading roles for current user fromroleGraph
.TablesPriv
andDbPriv
, not only matching record with current user, but also with roles inRoles
field.Some comment change was caused by
goword
check before commit.It will block the commit if I don't chenge these comment.
Check List
Tests
Code changes
Side effects